Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2801073002: [vr] Use base's time classes (Closed)

Created:
3 years, 8 months ago by Ian Vollick
Modified:
3 years, 8 months ago
Reviewers:
mthiesse
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[vr] Use base's time classes This is in keeping with other chromium code, and will let me take advantage of other code that expects these types. BUG=None Review-Url: https://codereview.chromium.org/2801073002 Cr-Commit-Position: refs/heads/master@{#462638} Committed: https://chromium.googlesource.com/chromium/src/+/dc861335a918da09c572e6ecd8c270952ecf6735

Patch Set 1 #

Patch Set 2 : updated tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -90 lines) Patch
M chrome/browser/android/vr_shell/animation.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/android/vr_shell/animation.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_elements.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/ui_elements.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_elements_unittest.cc View 1 4 chunks +58 lines, -46 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene.h View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene.cc View 6 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_unittest.cc View 1 7 chunks +26 lines, -17 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_gl.cc View 4 chunks +4 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (10 generated)
mthiesse
lgtm
3 years, 8 months ago (2017-04-06 14:56:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801073002/1
3 years, 8 months ago (2017-04-06 15:05:28 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/243272)
3 years, 8 months ago (2017-04-06 15:34:32 UTC) #10
Ian Vollick
On 2017/04/06 15:34:32, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 8 months ago (2017-04-06 20:29:43 UTC) #11
mthiesse
Still lgtm
3 years, 8 months ago (2017-04-06 20:33:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801073002/20001
3 years, 8 months ago (2017-04-06 20:40:35 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 21:57:35 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dc861335a918da09c572e6ecd8c2...

Powered by Google App Engine
This is Rietveld 408576698