Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2801053002:
Enable SwiftShader unit tests on Mac FYI try bots. (Closed)
|
Created:
3 years, 8 months ago by capn Modified:
3 years, 8 months ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable SwiftShader unit tests on Mac FYI try bots.
BUG=
Change-Id: Idbd1d57aa18e0fb15b0b4fdf23bebffc34090d91
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2801053002
Cr-Commit-Position: refs/heads/master@{#462725}
Committed: https://chromium.googlesource.com/chromium/src/+/40ff0dceb73531dd306ed197d13f96ef7e290188
Patch Set 1 #Patch Set 2 : Rebase to use new EGL unit test. #Patch Set 3 : Script output added. #
Messages
Total messages: 23 (16 generated)
Description was changed from ========== Enable SwiftShader unit tests on Mac FYI try bots. BUG= Change-Id: Idbd1d57aa18e0fb15b0b4fdf23bebffc34090d91 ========== to ========== Enable SwiftShader unit tests on Mac FYI try bots. BUG= Change-Id: Idbd1d57aa18e0fb15b0b4fdf23bebffc34090d91 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by capn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by capn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
Description was changed from ========== Enable SwiftShader unit tests on Mac FYI try bots. BUG= Change-Id: Idbd1d57aa18e0fb15b0b4fdf23bebffc34090d91 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Enable SwiftShader unit tests on Mac FYI try bots. BUG= Change-Id: Idbd1d57aa18e0fb15b0b4fdf23bebffc34090d91 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
capn@chromium.org changed reviewers: + kbr@chromium.org
PTAL. How do I test this on chromium.gpu.fyi to make sure we don't run into crbug.com/680820 again? I've tested swiftshader_unittests locally on my Mac.
On 2017/04/06 17:01:07, capn wrote: > PTAL. How do I test this on chromium.gpu.fyi to make sure we don't run into > crbug.com/680820 again? I've tested swiftshader_unittests locally on my Mac. You need to run this script to regenerate the .json files. At that point this should run on the mac_optional_gpu_tests_rel tryserver (since the predicate is Predicates.FYI_AND_OPTIONAL).
The CQ bit was checked by capn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/04/06 20:25:23, Ken Russell wrote: > On 2017/04/06 17:01:07, capn wrote: > > PTAL. How do I test this on chromium.gpu.fyi to make sure we don't run into > > crbug.com/680820 again? I've tested swiftshader_unittests locally on my Mac. > > You need to run this script to regenerate the .json files. At that point this > should run on the mac_optional_gpu_tests_rel tryserver (since the predicate is > Predicates.FYI_AND_OPTIONAL). Done. PTAL
lgtm We should consider moving these tests to non-GPU bots at some point in the future, since they can run on VMs whose time is cheaper.
On 2017/04/06 23:19:24, Ken Russell wrote: > lgtm > > We should consider moving these tests to non-GPU bots at some point in the > future, since they can run on VMs whose time is cheaper. Noted.
The CQ bit was checked by capn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491523266128390,
"parent_rev": "87f32deba6f0a1a629f55d3a57d4d52cba412427", "commit_rev":
"40ff0dceb73531dd306ed197d13f96ef7e290188"}
Message was sent while issue was closed.
Description was changed from ========== Enable SwiftShader unit tests on Mac FYI try bots. BUG= Change-Id: Idbd1d57aa18e0fb15b0b4fdf23bebffc34090d91 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Enable SwiftShader unit tests on Mac FYI try bots. BUG= Change-Id: Idbd1d57aa18e0fb15b0b4fdf23bebffc34090d91 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2801053002 Cr-Commit-Position: refs/heads/master@{#462725} Committed: https://chromium.googlesource.com/chromium/src/+/40ff0dceb73531dd306ed197d13f... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/40ff0dceb73531dd306ed197d13f... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
