Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2801033003: Avoid key error for custom machine types (Closed)

Created:
3 years, 8 months ago by kjlubick
Modified:
3 years, 8 months ago
Reviewers:
borenet, M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, borenet
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M appengine/swarming/swarming_bot/api/os_utilities.py View 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 11 (5 generated)
kjlubick
We noticed quarantine errors like https://paste.googleplex.com/4977214210703360
3 years, 8 months ago (2017-04-07 12:13:48 UTC) #2
M-A Ruel
lgtm Thanks, I had told Ravi that I'd fix it in an hour but you ...
3 years, 8 months ago (2017-04-07 12:18:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801033003/1
3 years, 8 months ago (2017-04-07 12:18:31 UTC) #5
borenet
https://codereview.chromium.org/2801033003/diff/1/appengine/swarming/swarming_bot/api/os_utilities.py File appengine/swarming/swarming_bot/api/os_utilities.py (right): https://codereview.chromium.org/2801033003/diff/1/appengine/swarming/swarming_bot/api/os_utilities.py#newcode415 appengine/swarming/swarming_bot/api/os_utilities.py:415: machine_cost = GCE_MACHINE_COST_HOUR_US.get(machine_type, 0.) I suspect we'll want a ...
3 years, 8 months ago (2017-04-07 12:19:26 UTC) #7
M-A Ruel
https://codereview.chromium.org/2801033003/diff/1/appengine/swarming/swarming_bot/api/os_utilities.py File appengine/swarming/swarming_bot/api/os_utilities.py (right): https://codereview.chromium.org/2801033003/diff/1/appengine/swarming/swarming_bot/api/os_utilities.py#newcode415 appengine/swarming/swarming_bot/api/os_utilities.py:415: machine_cost = GCE_MACHINE_COST_HOUR_US.get(machine_type, 0.) On 2017/04/07 12:19:25, borenet wrote: ...
3 years, 8 months ago (2017-04-07 12:20:16 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 12:22:49 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/23f369607252c4d23b7cf2ac74df96c2ca2f4372

Powered by Google App Engine
This is Rietveld 408576698