Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: components/exo/wm_helper_ash.cc

Issue 2801023004: chromeos: Fix chrome --mus startup crashes on device (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/chrome_browser_main_chromeos.cc ('k') | components/exo/wm_helper_mus.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/exo/wm_helper_ash.cc
diff --git a/components/exo/wm_helper_ash.cc b/components/exo/wm_helper_ash.cc
index 738a04095d44c84d9c910947955d983849a0784a..72850ee854ade01d9126e71ede7e17fb71216298 100644
--- a/components/exo/wm_helper_ash.cc
+++ b/components/exo/wm_helper_ash.cc
@@ -8,6 +8,7 @@
#include "ash/common/system/tray/system_tray_notifier.h"
#include "ash/common/wm/maximize_mode/maximize_mode_controller.h"
#include "ash/common/wm_shell.h"
+#include "ash/public/cpp/config.h"
#include "ash/shell.h"
#include "base/memory/singleton.h"
#include "ui/aura/client/focus_client.h"
@@ -23,12 +24,16 @@ namespace exo {
WMHelperAsh::WMHelperAsh() {
ash::Shell::Get()->AddShellObserver(this);
ash::Shell::Get()->activation_client()->AddObserver(this);
- ash::Shell::Get()->cursor_manager()->AddObserver(this);
+ // TODO(crbug.com/631103): Mushrome doesn't have a cursor manager yet.
+ if (ash::WmShell::Get()->GetAshConfig() != ash::Config::MUS)
+ ash::Shell::Get()->cursor_manager()->AddObserver(this);
ash::WmShell::Get()->AddDisplayObserver(this);
aura::client::FocusClient* focus_client =
aura::client::GetFocusClient(ash::Shell::GetPrimaryRootWindow());
focus_client->AddObserver(this);
- ui::DeviceDataManager::GetInstance()->AddObserver(this);
+ // TODO(crbug.com/709225): Mushrome doesn't have a DeviceDataManager.
+ if (ash::WmShell::Get()->GetAshConfig() != ash::Config::MUS)
+ ui::DeviceDataManager::GetInstance()->AddObserver(this);
ash::Shell::Get()->system_tray_notifier()->AddAccessibilityObserver(this);
}
@@ -39,10 +44,14 @@ WMHelperAsh::~WMHelperAsh() {
aura::client::GetFocusClient(ash::Shell::GetPrimaryRootWindow());
focus_client->RemoveObserver(this);
ash::WmShell::Get()->RemoveDisplayObserver(this);
- ash::Shell::Get()->cursor_manager()->RemoveObserver(this);
+ // TODO(crbug.com/631103): Mushrome doesn't have a cursor manager yet.
+ if (ash::WmShell::Get()->GetAshConfig() != ash::Config::MUS)
+ ash::Shell::Get()->cursor_manager()->RemoveObserver(this);
ash::Shell::Get()->activation_client()->RemoveObserver(this);
ash::Shell::Get()->RemoveShellObserver(this);
- ui::DeviceDataManager::GetInstance()->RemoveObserver(this);
+ // TODO(crbug.com/709225): Mushrome doesn't have a DeviceDataManager.
+ if (ash::WmShell::Get()->GetAshConfig() != ash::Config::MUS)
+ ui::DeviceDataManager::GetInstance()->RemoveObserver(this);
ash::Shell::Get()->system_tray_notifier()->RemoveAccessibilityObserver(this);
}
@@ -70,6 +79,9 @@ aura::Window* WMHelperAsh::GetFocusedWindow() const {
}
ui::CursorSetType WMHelperAsh::GetCursorSet() const {
+ // TODO(crbug.com/631103): Mushrome doesn't have a cursor manager yet.
+ if (ash::WmShell::Get()->GetAshConfig() == ash::Config::MUS)
+ return ui::CURSOR_SET_NORMAL;
return ash::Shell::Get()->cursor_manager()->GetCursorSet();
}
« no previous file with comments | « chrome/browser/chromeos/chrome_browser_main_chromeos.cc ('k') | components/exo/wm_helper_mus.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698