DescriptionRevert of Implemented parseSingleValue in CSSPropertyAPICounterIncrement.
(patchset #4 id:60001 of https://codereview.chromium.org/2783543002/ )
Reason for revert:
LIkely cause of compile failure on Android builders:
const blink::CSSParserContext*)' does not match any in class 'blink::CSSPropertyAPICounterIncrement'
const CSSValue* CSSPropertyAPICounterIncrement::parseSingleValue(
^
Original issue's description:
> Implemented parseSingleValue in CSSPropertyAPICounterIncrement.
>
> Part of Project Ribbon, separating the parsing logic for CSS
> properties from the parser into an API.
>
> This patch
> - added parseSingleValue method to the CSSPropertyAPICounterIncrement
> API, with parsing logic from CSSPropertyParser
> - removed CSSPropertyCounterIncrement from the switch statement in
> CSSPropertyParser::parseSingleValue, calling the API instead using
> a CSSPropertyDescriptor
> - added parseSingleValue to counter-increment in CSSProperties.json5
> so it will be added to the generated files for the api
>
> Diff in generated CSSPropertyAPICounterIncrement.h:
> https://gist.github.com/BugsNash/ac16598cbe0677824308a64a52e33213/revisions
> Diff in generated CSSPropertyDescriptor.cpp:
> https://gist.github.com/BugsNash/7156559ba47f4ac929951959fe19cb93/revisions
>
> BUG=668012
>
> Review-Url: https://codereview.chromium.org/2783543002
> Cr-Commit-Position: refs/heads/master@{#462379}
> Committed: https://chromium.googlesource.com/chromium/src/+/16f5c5b2155faa46890e2c5ad18bd27f7c506deb
TBR=ericwilligers@chromium.org,meade@chromium.org,bugsnash@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=668012
Review-Url: https://codereview.chromium.org/2801023002
Cr-Commit-Position: refs/heads/master@{#462384}
Committed: https://chromium.googlesource.com/chromium/src/+/c68471e6f7e1d8570d209ab7221bced498e262d6
Patch Set 1 #
Messages
Total messages: 7 (4 generated)
|