Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 2801023002: Revert of Implemented parseSingleValue in CSSPropertyAPICounterIncrement. (Closed)

Created:
3 years, 8 months ago by awdf
Modified:
3 years, 8 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implemented parseSingleValue in CSSPropertyAPICounterIncrement. (patchset #4 id:60001 of https://codereview.chromium.org/2783543002/ ) Reason for revert: LIkely cause of compile failure on Android builders: const blink::CSSParserContext*)' does not match any in class 'blink::CSSPropertyAPICounterIncrement' const CSSValue* CSSPropertyAPICounterIncrement::parseSingleValue( ^ Original issue's description: > Implemented parseSingleValue in CSSPropertyAPICounterIncrement. > > Part of Project Ribbon, separating the parsing logic for CSS > properties from the parser into an API. > > This patch > - added parseSingleValue method to the CSSPropertyAPICounterIncrement > API, with parsing logic from CSSPropertyParser > - removed CSSPropertyCounterIncrement from the switch statement in > CSSPropertyParser::parseSingleValue, calling the API instead using > a CSSPropertyDescriptor > - added parseSingleValue to counter-increment in CSSProperties.json5 > so it will be added to the generated files for the api > > Diff in generated CSSPropertyAPICounterIncrement.h: > https://gist.github.com/BugsNash/ac16598cbe0677824308a64a52e33213/revisions > Diff in generated CSSPropertyDescriptor.cpp: > https://gist.github.com/BugsNash/7156559ba47f4ac929951959fe19cb93/revisions > > BUG=668012 > > Review-Url: https://codereview.chromium.org/2783543002 > Cr-Commit-Position: refs/heads/master@{#462379} > Committed: https://chromium.googlesource.com/chromium/src/+/16f5c5b2155faa46890e2c5ad18bd27f7c506deb TBR=ericwilligers@chromium.org,meade@chromium.org,bugsnash@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=668012 Review-Url: https://codereview.chromium.org/2801023002 Cr-Commit-Position: refs/heads/master@{#462384} Committed: https://chromium.googlesource.com/chromium/src/+/c68471e6f7e1d8570d209ab7221bced498e262d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -13 lines) Patch
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/properties/CSSPropertyAPICounterIncrement.cpp View 1 chunk +1 line, -12 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
awdf
Created Revert of Implemented parseSingleValue in CSSPropertyAPICounterIncrement.
3 years, 8 months ago (2017-04-06 07:32:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801023002/1
3 years, 8 months ago (2017-04-06 07:32:20 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 07:36:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c68471e6f7e1d8570d209ab7221b...

Powered by Google App Engine
This is Rietveld 408576698