Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2800973004: Add component and team info to some //testing, //tools OWNERS files. (Closed)

Created:
3 years, 8 months ago by Dirk Pranke
Modified:
3 years, 8 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add component and team info to some //testing, //tools OWNERS files. This adds some basic TEAM and COMPONENT info for the top-level //testing and //tools files and a few subdirectories, where either the right owners are in infra or we don't really have good owners but might as well pick something. This also adds a TEAM entry for //build. R=phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2800973004 Cr-Commit-Position: refs/heads/master@{#463048} Committed: https://chromium.googlesource.com/chromium/src/+/9d705ef39020eddba9be5d940b88d1bfd82b6834

Patch Set 1 #

Patch Set 2 : add TEAM to //build #

Total comments: 6

Patch Set 3 : use Infra>Client>Chrome instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -5 lines) Patch
M build/OWNERS View 1 1 chunk +5 lines, -0 lines 0 comments Download
M testing/OWNERS View 1 chunk +7 lines, -0 lines 0 comments Download
M testing/buildbot/OWNERS View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M testing/buildbot/filters/OWNERS View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M testing/scripts/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M tools/OWNERS View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/mb/OWNERS View 1 chunk +6 lines, -2 lines 0 comments Download
M tools/md_browser/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Dirk Pranke
3 years, 8 months ago (2017-04-07 02:09:20 UTC) #2
Paweł Hajdan Jr.
LGTM w/optional suggestions https://codereview.chromium.org/2800973004/diff/20001/testing/buildbot/OWNERS File testing/buildbot/OWNERS (right): https://codereview.chromium.org/2800973004/diff/20001/testing/buildbot/OWNERS#newcode34 testing/buildbot/OWNERS:34: # COMPONENT: Infra>Client Consider changing to ...
3 years, 8 months ago (2017-04-07 16:13:06 UTC) #3
Dirk Pranke
Good suggestions, will do.
3 years, 8 months ago (2017-04-07 18:19:32 UTC) #4
Dirk Pranke
https://codereview.chromium.org/2800973004/diff/20001/testing/buildbot/OWNERS File testing/buildbot/OWNERS (right): https://codereview.chromium.org/2800973004/diff/20001/testing/buildbot/OWNERS#newcode34 testing/buildbot/OWNERS:34: # COMPONENT: Infra>Client On 2017/04/07 16:13:05, Paweł Hajdan Jr. ...
3 years, 8 months ago (2017-04-07 20:53:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800973004/40001
3 years, 8 months ago (2017-04-07 20:54:09 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 23:30:00 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9d705ef39020eddba9be5d940b88...

Powered by Google App Engine
This is Rietveld 408576698