Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2800973003: [Home] Fix bottom navigation appearance (Closed)

Created:
3 years, 8 months ago by Theresa
Modified:
3 years, 8 months ago
Reviewers:
mdjones
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Home] Fix bottom navigation appearance When the available screen height is small the BottomSheet skips the half state, so using #onTransitionPeekToHalf() is an unreliable way to make the bottom nav visible. Use @onSheetOFfsetChanged() instead BUG= Review-Url: https://codereview.chromium.org/2800973003 Cr-Commit-Position: refs/heads/master@{#462672} Committed: https://chromium.googlesource.com/chromium/src/+/159d6ca4b5a90854d66bca1a7efcf03193d369bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Theresa
ptal
3 years, 8 months ago (2017-04-06 21:40:08 UTC) #3
mdjones
lgtm; I'll look into fixing that event too. The max height might not reach the ...
3 years, 8 months ago (2017-04-06 23:00:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800973003/1
3 years, 8 months ago (2017-04-06 23:03:23 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 23:18:34 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/159d6ca4b5a90854d66bca1a7efc...

Powered by Google App Engine
This is Rietveld 408576698