Rename checkpoint() method to getCheckpoint().

Rename checkpoint() method to getCheckpoint().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |Checkpoint| type
alias and a |checkpoint| accessor method (differing by case of the first
character); after a naive rename by the rewrite_to_chrome_style tool we
would end up with |Checkpoint| being the name of both the type and the
accessor method (with both living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
TBR=japhet@chromium.org

Review-Url: https://codereview.chromium.org/2800963003
Cr-Commit-Position: refs/heads/master@{#462648}
Committed: https://chromium.googlesource.com/chromium/src/+/be9dfc362a8b2b90e054b5142c55c28334a6bded

[Łukasz Anforowicz, 2017-04-06 20:56:34]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 20:57:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2017-04-06 21:00:18]

japhet@, FYI - I plan to TBR this CL, because:

1. It is quite a safe, mechanical rename of a method (and it follows the pattern
of other already landed CLs for https://crbug.com/582312)

2. We are trying to flush out all the known issues before trying to perform the
Great Blink Rename this coming weekend (and I hope to land this CL soon, to
squeeze in one more dry-run on before Saturday).

[dcheng, 2017-04-06 21:03:30]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2017-04-06 21:03:31]

lgtm

[Łukasz Anforowicz, 2017-04-06 21:20:46]

The CQ bit was unchecked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-04-06 21:20:51]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2017-04-06 21:21:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 22:21:10]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491513651839500, "parent_rev":
"08c55238f86f197b7f64f6e732065be266de2baa", "commit_rev":
"be9dfc362a8b2b90e054b5142c55c28334a6bded"}

[commit-bot: I haz the power, 2017-04-06 22:21:59]

Description was changed from

==========
Rename checkpoint() method to getCheckpoint().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |Checkpoint| type
alias and a |checkpoint| accessor method (differing by case of the first
character); after a naive rename by the rewrite_to_chrome_style tool we
would end up with |Checkpoint| being the name of both the type and the
accessor method (with both living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
TBR=japhet@chromium.org
==========

to

==========
Rename checkpoint() method to getCheckpoint().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |Checkpoint| type
alias and a |checkpoint| accessor method (differing by case of the first
character); after a naive rename by the rewrite_to_chrome_style tool we
would end up with |Checkpoint| being the name of both the type and the
accessor method (with both living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
TBR=japhet@chromium.org

Review-Url: https://codereview.chromium.org/2800963003
Cr-Commit-Position: refs/heads/master@{#462648}
Committed:
https://chromium.googlesource.com/chromium/src/+/be9dfc362a8b2b90e054b5142c55...
==========

[commit-bot: I haz the power, 2017-04-06 22:21:59]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/be9dfc362a8b2b90e054b5142c55...