Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2800963002: [Merge to M58] cros: Treat set rotation for chrome.system.display API in touchview mode as if user … (Closed)

Created:
3 years, 8 months ago by Qiang(Joe) Xu
Modified:
3 years, 8 months ago
Reviewers:
lazyboy, oshima
CC:
chromium-reviews, mlamouri+watch-screen-orientation_chromium.org, kalyank, sadrul, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Merge to M58] cros: Treat set rotation for chrome.system.display API in touchview mode as if user rotation lock Changes: Expose an API SetLockToOrientation for chrome.system.display set rotation that will do the work like user rotation lock. TBR=oshima@chromium.org, lazyboy@chromium.org BUG=704931 TEST=test coverage Review-Url: https://codereview.chromium.org/2784043002 Cr-Commit-Position: refs/heads/master@{#461559} (cherry picked from commit c5bd9a545c026646b4f9bc35aba650ff01c87edd) Review-Url: https://codereview.chromium.org/2800963002 . Cr-Commit-Position: refs/branch-heads/3029@{#596} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/1eee5372d66a84bf36087728f0c39ed087d92f4b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -22 lines) Patch
M ash/display/screen_orientation_controller_chromeos.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ash/display/screen_orientation_controller_chromeos.cc View 2 chunks +22 lines, -9 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos.cc View 3 chunks +19 lines, -3 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos_unittest.cc View 4 chunks +16 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Qiang(Joe) Xu
3 years, 8 months ago (2017-04-05 23:21:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1eee5372d66a84bf36087728f0c39ed087d92f4b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698