Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2800883004: Port cpplint's C++11 raw string support to blink's cpp style checker. (Closed)

Created:
3 years, 8 months ago by Nico
Modified:
3 years, 8 months ago
Reviewers:
dcheng
CC:
chromium-reviews, blink-reviews, blink-reviews-style_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Port cpplint's C++11 raw string support to blink's cpp style checker. Ports the raw string bits from https://github.com/cpplint/cpplint/commit/2aa5998d820bba053c214543c05a739b9b496fa3 Also do the gratutious style rejiggering that webkitpy has done to the original (four-space indent, line_number instead of linenum, etc.) BUG=708782 Review-Url: https://codereview.chromium.org/2800883004 Cr-Commit-Position: refs/heads/master@{#462332} Committed: https://chromium.googlesource.com/chromium/src/+/c21b004df95e3c751bcef1d8bfc0a793140d9410

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -16 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py View 9 chunks +101 lines, -16 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py View 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Nico
3 years, 8 months ago (2017-04-06 01:19:08 UTC) #3
dcheng
LGTM (Do we care about 80 chars in cpp.py?)
3 years, 8 months ago (2017-04-06 01:25:10 UTC) #5
Nico
On 2017/04/06 01:25:10, dcheng wrote: > LGTM > > (Do we care about 80 chars ...
3 years, 8 months ago (2017-04-06 01:28:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800883004/1
3 years, 8 months ago (2017-04-06 01:28:35 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 02:40:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c21b004df95e3c751bcef1d8bfc0...

Powered by Google App Engine
This is Rietveld 408576698