Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2800883003: [CrOS Tether] Update SecureChannel and BleConnectionManager to use CryptAuthService instead of a Del (Closed)

Created:
3 years, 8 months ago by Kyle Horimoto
Modified:
3 years, 8 months ago
CC:
chromium-reviews, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, jlklein+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org, tengs+watch-tether_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CrOS Tether] Update SecureChannel and BleConnectionManager to use CryptAuthService instead of a Delegate. BUG=672263 Review-Url: https://codereview.chromium.org/2800883003 Cr-Commit-Position: refs/heads/master@{#462687} Committed: https://chromium.googlesource.com/chromium/src/+/380df565e65bff274f6ceaef2c44f1020218b7be

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased. #

Patch Set 4 : Rebased. #

Patch Set 5 : Added BleConnectionManager refactor as well. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -100 lines) Patch
M chromeos/components/tether/ble_connection_manager.h View 1 2 3 4 4 chunks +4 lines, -9 lines 0 comments Download
M chromeos/components/tether/ble_connection_manager.cc View 1 2 3 4 4 chunks +7 lines, -6 lines 0 comments Download
M chromeos/components/tether/ble_connection_manager_unittest.cc View 1 2 3 4 7 chunks +10 lines, -31 lines 0 comments Download
M components/cryptauth/fake_secure_channel.h View 1 chunk +3 lines, -1 line 0 comments Download
M components/cryptauth/fake_secure_channel.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/cryptauth/secure_channel.h View 4 chunks +6 lines, -12 lines 0 comments Download
M components/cryptauth/secure_channel.cc View 6 chunks +10 lines, -12 lines 0 comments Download
M components/cryptauth/secure_channel_unittest.cc View 5 chunks +6 lines, -27 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Kyle Horimoto
3 years, 8 months ago (2017-04-06 01:05:04 UTC) #2
Ryan Hansberry
lgtm
3 years, 8 months ago (2017-04-06 15:12:23 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 2799683004 Patch 60001). Please resolve the dependency and ...
3 years, 8 months ago (2017-04-06 15:12:46 UTC) #6
Jeremy Klein
lgtm
3 years, 8 months ago (2017-04-06 17:14:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800883003/80001
3 years, 8 months ago (2017-04-06 22:42:21 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 23:44:54 UTC) #15
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/380df565e65bff274f6ceaef2c44...

Powered by Google App Engine
This is Rietveld 408576698