Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2800863006: 📰 Delete dead code in NewTabPageScrollView. (Closed)

Created:
3 years, 8 months ago by Michael van Ouwerkerk
Modified:
3 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Suggestions] Delete dead code in NewTabPageScrollView. Review-Url: https://codereview.chromium.org/2800863006 Cr-Commit-Position: refs/heads/master@{#462903} Committed: https://chromium.googlesource.com/chromium/src/+/6fc9ec0f007de2e5f92a895ee83fb3c3ba2a475c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -58 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageScrollView.java View 3 chunks +1 line, -58 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Michael van Ouwerkerk
Bernhard, could you take a look please?
3 years, 8 months ago (2017-04-07 16:41:33 UTC) #5
Bernhard Bauer
lgtm
3 years, 8 months ago (2017-04-07 16:50:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800863006/1
3 years, 8 months ago (2017-04-07 16:53:12 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 17:15:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6fc9ec0f007de2e5f92a895ee83f...

Powered by Google App Engine
This is Rietveld 408576698