Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 2800863004: Update Blink OWNERS file for tooling info. (Closed)

Created:
3 years, 8 months ago by Dirk Pranke
Modified:
3 years, 8 months ago
CC:
abarth-chromium, blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Blink OWNERS file for tooling info. This CL updates the OWNERS information for //third_party/WebKit/Tools and //blink/tools to be current (including adding TEAM and COMPONENT info), and also adds a preparatory OWNER stub for //blink and tweaks a few lines in //third_party/WebKit. This CL removes jochen@, peter@, and tony@ as owners, as they haven't committed anything to the tools code in some time, and adds the current contributors. I should probably remove myself as an owner as well, but I'll let that go for a few more months. This CL also removes the wildcard "*" owner from Tools/Scripts, as there's no needd for that to be a wildcard these days, and the blink infra folks should review all changes. R=qyearsley@chromium.org, jeffcarp@chromium.org, tansell@chromium.org, wangxianzhu@chromium.org, tkent@chromium.org, jochen@chromium.org, peter@chromium.org Review-Url: https://codereview.chromium.org/2800863004 Cr-Commit-Position: refs/heads/master@{#463002} Committed: https://chromium.googlesource.com/chromium/src/+/f0967b500becdadb10fa3b91bea592105fb74730

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
A blink/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M blink/tools/OWNERS View 1 chunk +8 lines, -2 lines 0 comments Download
M third_party/WebKit/OWNERS View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Tools/OWNERS View 1 chunk +6 lines, -3 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (5 generated)
Dirk Pranke
Hi all, Please let me know if you have any objections to any of these ...
3 years, 8 months ago (2017-04-07 01:47:30 UTC) #3
tkent
We won't use //blink, but anyway this CL lgtm.
3 years, 8 months ago (2017-04-07 01:50:42 UTC) #4
Peter Beverloo
also lgtm
3 years, 8 months ago (2017-04-07 01:52:09 UTC) #5
mithro
lgtm
3 years, 8 months ago (2017-04-07 06:40:29 UTC) #6
jochen (gone - plz use gerrit)
hum, not sure whether contributing code should be a precondition for remaining an owner In ...
3 years, 8 months ago (2017-04-07 06:52:18 UTC) #7
qyearsley
No objections, lgtm
3 years, 8 months ago (2017-04-07 16:01:20 UTC) #8
jeffcarp
lgtm
3 years, 8 months ago (2017-04-07 16:29:03 UTC) #9
Dirk Pranke
On 2017/04/07 06:52:18, jochen wrote: > hum, not sure whether contributing code should be a ...
3 years, 8 months ago (2017-04-07 18:18:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800863004/1
3 years, 8 months ago (2017-04-07 18:20:03 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f0967b500becdadb10fa3b91bea592105fb74730
3 years, 8 months ago (2017-04-07 21:10:49 UTC) #15
mithro
Maybe someone like Pawel or Sergiy could help provide EMEA coverage. They aren't really working ...
3 years, 8 months ago (2017-04-10 01:35:19 UTC) #16
jochen (gone - plz use gerrit)
3 years, 8 months ago (2017-04-10 07:49:31 UTC) #17
Message was sent while issue was closed.
On 2017/04/10 at 01:35:19, tansell wrote:
> Maybe someone like Pawel or Sergiy could help provide EMEA coverage. They
aren't really working on Blink tooling but do have a lot of context about more
general Chrome Infa.

I don't think that makes sense - I'd claim to still have more context about the
stuff there (and as I noted in comment #7, I'm still an owner anyways, as I'm in
the blink/OWNERS file)

Powered by Google App Engine
This is Rietveld 408576698