Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2800853007: Make the answers text color more consistent. (Closed)

Created:
3 years, 8 months ago by Justin Donnelly
Modified:
3 years, 8 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, jdonnelly+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the answers text color more consistent. All answer text (other than the suggestion text and positive/negative text) is now the de-emphasizing gray. BUG=709101 Review-Url: https://codereview.chromium.org/2800853007 Cr-Commit-Position: refs/heads/master@{#463170} Committed: https://chromium.googlesource.com/chromium/src/+/1ab7c6059c16600fd7e1ffbb727e4aa2726d854e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 12 (8 generated)
Justin Donnelly
3 years, 8 months ago (2017-04-07 22:13:25 UTC) #4
groby-ooo-7-16
lgtm https://codereview.chromium.org/2800853007/diff/1/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm File chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm (right): https://codereview.chromium.org/2800853007/diff/1/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm#newcode151 chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm:151: NSForegroundColorAttributeName : DimTextColor(is_dark_theme), I wish we could get ...
3 years, 8 months ago (2017-04-07 23:54:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800853007/1
3 years, 8 months ago (2017-04-10 02:56:50 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 03:17:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1ab7c6059c16600fd7e1ffbb727e...

Powered by Google App Engine
This is Rietveld 408576698