Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2800853005: Verify rethrow and parent's of variables. (Closed)

Created:
3 years, 8 months ago by ahe
Modified:
3 years, 8 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments and camelCase. #

Patch Set 3 : Update status files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M pkg/front_end/test/fasta/compile.status View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/kernel/lib/verifier.dart View 1 3 chunks +29 lines, -0 lines 0 comments Download
M pkg/pkg.status View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ahe
3 years, 8 months ago (2017-04-07 08:13:20 UTC) #2
asgerf
lgtm https://codereview.chromium.org/2800853005/diff/1/pkg/kernel/lib/verifier.dart File pkg/kernel/lib/verifier.dart (right): https://codereview.chromium.org/2800853005/diff/1/pkg/kernel/lib/verifier.dart#newcode280 pkg/kernel/lib/verifier.dart:280: inCatchBlock = savedinCatchBlock; Also save and set to ...
3 years, 8 months ago (2017-04-07 08:52:52 UTC) #4
ahe
Thank you, Asger! https://codereview.chromium.org/2800853005/diff/1/pkg/kernel/lib/verifier.dart File pkg/kernel/lib/verifier.dart (right): https://codereview.chromium.org/2800853005/diff/1/pkg/kernel/lib/verifier.dart#newcode280 pkg/kernel/lib/verifier.dart:280: inCatchBlock = savedinCatchBlock; On 2017/04/07 08:52:52, ...
3 years, 8 months ago (2017-04-07 10:43:39 UTC) #5
ahe
3 years, 8 months ago (2017-04-07 10:59:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
6b150cb01fdbad1c247f7e79d5e86f8dc6359ffb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698