Verify rethrow and parent's of variables.

pkg/kernel/lib/verifier.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 library kernel.checks;
 
 import 'ast.dart';
 import 'transformations/flags.dart';
 
 void verifyProgram(Program program) {
   VerifyingVisitor.check(program);
@@ skipping 33 matching lines @@
 class VerifyingVisitor extends RecursiveVisitor {
   final Set<Class> classes = new Set<Class>();
   final Set<TypeParameter> typeParameters = new Set<TypeParameter>();
   final List<VariableDeclaration> variableStack = <VariableDeclaration>[];
   bool classTypeParametersAreInScope = false;
 
   /// If true, relax certain checks for *outline* mode. For example, don't
   /// attempt to validate constructor initializers.
   bool isOutline = false;
 
+  bool inCatchBlock = false;
+
   Member currentMember;
   Class currentClass;
   TreeNode currentParent;
 
   TreeNode get context => currentMember ?? currentClass;
 
   static void check(Program program) {
     program.accept(new VerifyingVisitor());
   }
 
@@ skipping 201 matching lines @@
 
   visitForInStatement(ForInStatement node) {
     visitWithLocalScope(node);
   }
 
   visitLet(Let node) {
     visitWithLocalScope(node);
   }
 
   visitCatch(Catch node) {
+    bool savedinCatchBlock = inCatchBlock;
+    inCatchBlock = true;
     visitWithLocalScope(node);
+    inCatchBlock = savedinCatchBlock;

[asgerf, 2017/04/07 08:52:52]

Also save and set to false in visitFunctionNode.

[ahe, 2017/04/07 10:43:39]

Good point. I know another file where I need to do the same ;-)

+  }
+
+  @override
+  visitRethrow(Rethrow node) {
+    if (!inCatchBlock) {
+      problem(node, "Rethrow must be inside a Catch block.");
+    }
   }
 
   visitVariableDeclaration(VariableDeclaration node) {
+    var parent = node.parent;
+    if (parent is! Block &&
+        !(parent is Catch && parent.body != node) &&
+        !(parent is FunctionNode && parent.body != node) &&
+        parent is! FunctionDeclaration &&
+        !(parent is ForStatement && parent.body != node) &&
+        !(parent is ForInStatement && parent.body != node) &&
+        parent is! Let &&
+        parent is! LocalInitializer) {
+      problem(
+          node,
+          "VariableDeclaration must be a direct child of a Block, "
+          "not ${parent.runtimeType}.");
+    }
     visitChildren(node);
     declareVariable(node);
   }
 
   visitVariableGet(VariableGet node) {
     checkVariableInScope(node.variable, node);
     visitChildren(node);
   }
 
   visitVariableSet(VariableSet node) {
@@ skipping 224 matching lines @@
     var oldParent = parent;
     parent = node;
     node.visitChildren(this);
     parent = oldParent;
   }
 }
 
 void checkInitializers(Constructor constructor) {
   // TODO(ahe): I'll add more here in other CLs.
 }