Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2800833005: Remove SurfaceFactory Occurrences Outside Of cc (Closed)

Created:
3 years, 8 months ago by Alex Z.
Modified:
3 years, 8 months ago
Reviewers:
danakj, Fady Samuel, piman
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, Ian Vollick, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, jam, xjz+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, cc-bugs_chromium.org, James Su, danakj+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SurfaceFactory Occurrences Outside Of cc SurfaceFactory and SurfaceFactoryClient is being removed. This CL removes SurfaceFactory usages outside of cc. BUG=707105 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2800833005 Cr-Commit-Position: refs/heads/master@{#463460} Committed: https://chromium.googlesource.com/chromium/src/+/86ccbc2d91a472b49db3dc48ba9c586eaa1995d5

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 2

Patch Set 3 : Make SurfaceFactoryClient Implementation In CompositorFrameSinkSupport Public #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -70 lines) Patch
M cc/surfaces/compositor_frame_sink_support.h View 1 2 2 chunks +10 lines, -10 lines 0 comments Download
M cc/surfaces/compositor_frame_sink_support.cc View 1 2 2 chunks +51 lines, -51 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/delegated_frame_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/compositor_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 30 (21 generated)
Alex Z.
PTAL.
3 years, 8 months ago (2017-04-07 13:57:35 UTC) #6
Fady Samuel
lgtm
3 years, 8 months ago (2017-04-10 13:41:55 UTC) #13
Alex Z.
nasko@chromium.org: Please review changes in content. danakj@chromium.org: Please review changes in cc and ui/compositor.
3 years, 8 months ago (2017-04-10 13:47:44 UTC) #15
Alex Z.
piman@: Please review changes in content/.
3 years, 8 months ago (2017-04-10 13:51:57 UTC) #17
piman
https://codereview.chromium.org/2800833005/diff/20001/cc/surfaces/compositor_frame_sink_support.h File cc/surfaces/compositor_frame_sink_support.h (right): https://codereview.chromium.org/2800833005/diff/20001/cc/surfaces/compositor_frame_sink_support.h#newcode22 cc/surfaces/compositor_frame_sink_support.h:22: namespace content { This is a layering violation... If ...
3 years, 8 months ago (2017-04-10 17:46:10 UTC) #18
Alex Z.
https://codereview.chromium.org/2800833005/diff/20001/cc/surfaces/compositor_frame_sink_support.h File cc/surfaces/compositor_frame_sink_support.h (right): https://codereview.chromium.org/2800833005/diff/20001/cc/surfaces/compositor_frame_sink_support.h#newcode22 cc/surfaces/compositor_frame_sink_support.h:22: namespace content { On 2017/04/10 17:46:10, piman wrote: > ...
3 years, 8 months ago (2017-04-10 19:12:08 UTC) #21
piman
lgtm
3 years, 8 months ago (2017-04-10 19:53:52 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800833005/40001
3 years, 8 months ago (2017-04-11 00:05:29 UTC) #27
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 00:15:42 UTC) #30
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/86ccbc2d91a472b49db3dc48ba9c...

Powered by Google App Engine
This is Rietveld 408576698