Remove SurfaceFactory Occurrences Outside Of cc

Remove SurfaceFactory Occurrences Outside Of cc

SurfaceFactory and SurfaceFactoryClient is being removed.
This CL removes SurfaceFactory usages outside of cc.

BUG=707105
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2800833005
Cr-Commit-Position: refs/heads/master@{#463460}
Committed: https://chromium.googlesource.com/chromium/src/+/86ccbc2d91a472b49db3dc48ba9c586eaa1995d5

[Alex Z., 2017-04-07 13:57:04]

Description was changed from

==========
Remove SurfaceFactory Occurrences Outside Of cc

SurfaceFactory and SurfaceFactoryClient is being removed.
This CL removes SurfaceFactory usages outside of cc.

BUG=707105
==========

to

==========
Remove SurfaceFactory Occurrences Outside Of cc

SurfaceFactory and SurfaceFactoryClient is being removed.
This CL removes SurfaceFactory usages outside of cc.

BUG=707105
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Alex Z., 2017-04-07 13:57:04]

Description was changed from

==========
Remove SurfaceFactory Occurrences Outside Of cc

SurfaceFactory and SurfaceFactoryClient is being removed.
This CL removes SurfaceFactory usages outside of cc.

BUG=707105
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove SurfaceFactory Occurrences Outside Of cc

SurfaceFactory and SurfaceFactoryClient is being removed.
This CL removes SurfaceFactory usages outside of cc.

BUG=707105
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
==========

[Alex Z., 2017-04-07 13:57:09]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 13:57:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alex Z., 2017-04-07 13:57:34]

staraz@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Alex Z., 2017-04-07 13:57:35]

PTAL.

[commit-bot: I haz the power, 2017-04-07 13:58:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 13:58:38]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Alex Z., 2017-04-10 12:27:54]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 12:28:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 13:32:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 13:32:02]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2017-04-10 13:41:55]

lgtm

[Alex Z., 2017-04-10 13:47:44]

staraz@chromium.org changed reviewers:
+ danakj@chromium.org, nasko@chromium.org

[Alex Z., 2017-04-10 13:47:44]

nasko@chromium.org: Please review changes in content.

danakj@chromium.org: Please review changes in cc and ui/compositor.

[Alex Z., 2017-04-10 13:51:56]

staraz@chromium.org changed reviewers:
+ piman@chromium.org
- nasko@chromium.org

[Alex Z., 2017-04-10 13:51:57]

piman@: Please review changes in content/.

[piman, 2017-04-10 17:46:10]

https://codereview.chromium.org/2800833005/diff/20001/cc/surfaces/compositor_...
File cc/surfaces/compositor_frame_sink_support.h (right):

https://codereview.chromium.org/2800833005/diff/20001/cc/surfaces/compositor_...
cc/surfaces/compositor_frame_sink_support.h:22: namespace content {
This is a layering violation...
If all you need is SetBeginFrameSource, maybe you can add a
SetBeginFrameSourceForTest forwarding function instead?

[Alex Z., 2017-04-10 19:10:55]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 19:11:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alex Z., 2017-04-10 19:12:08]

https://codereview.chromium.org/2800833005/diff/20001/cc/surfaces/compositor_...
File cc/surfaces/compositor_frame_sink_support.h (right):

https://codereview.chromium.org/2800833005/diff/20001/cc/surfaces/compositor_...
cc/surfaces/compositor_frame_sink_support.h:22: namespace content {
On 2017/04/10 17:46:10, piman wrote:
> This is a layering violation...
> If all you need is SetBeginFrameSource, maybe you can add a
> SetBeginFrameSourceForTest forwarding function instead?

Following the discussion on Slack, the implementation of 
SurfaceFactoryClient is made public and thus the friendship is no 
longer needed.

[piman, 2017-04-10 19:53:52]

lgtm

[commit-bot: I haz the power, 2017-04-10 20:44:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 20:44:16]

Dry run: This issue passed the CQ dry run.

[Alex Z., 2017-04-11 00:04:36]

The CQ bit was checked by staraz@chromium.org

[Alex Z., 2017-04-11 00:04:36]

The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/2800833005/#ps40001
(title: "Make SurfaceFactoryClient Implementation In CompositorFrameSinkSupport
Public")

[commit-bot: I haz the power, 2017-04-11 00:05:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 00:13:43]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491869076539740,
"parent_rev": "474939fc1d9344c7fdbbb12638d4d318e9c57192", "commit_rev":
"86ccbc2d91a472b49db3dc48ba9c586eaa1995d5"}

[commit-bot: I haz the power, 2017-04-11 00:15:40]

Description was changed from

==========
Remove SurfaceFactory Occurrences Outside Of cc

SurfaceFactory and SurfaceFactoryClient is being removed.
This CL removes SurfaceFactory usages outside of cc.

BUG=707105
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove SurfaceFactory Occurrences Outside Of cc

SurfaceFactory and SurfaceFactoryClient is being removed.
This CL removes SurfaceFactory usages outside of cc.

BUG=707105
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2800833005
Cr-Commit-Position: refs/heads/master@{#463460}
Committed:
https://chromium.googlesource.com/chromium/src/+/86ccbc2d91a472b49db3dc48ba9c...
==========

[commit-bot: I haz the power, 2017-04-11 00:15:42]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/86ccbc2d91a472b49db3dc48ba9c...