Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2800703002: Disabling flaky CustomTabActivityTest#testTabReparentingSelectPopup (Closed)

Created:
3 years, 8 months ago by awdf
Modified:
3 years, 8 months ago
Reviewers:
Peter Beverloo, yusufo
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabling flaky CustomTabActivityTest#testTabReparentingSelectPopup TBR=yusufo BUG=707766 Review-Url: https://codereview.chromium.org/2800703002 Cr-Commit-Position: refs/heads/master@{#462059} Committed: https://chromium.googlesource.com/chromium/src/+/f2878c09d532945c3ffbe6f0386da36a89d693fb

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java View 1 chunk +3 lines, -2 lines 1 comment Download

Messages

Total messages: 7 (4 generated)
Peter Beverloo
lgtm https://codereview.chromium.org/2800703002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java (right): https://codereview.chromium.org/2800703002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java#newcode665 chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java:665: @DisabledTest // Disabled due to flakiness on browser_side_navigation ...
3 years, 8 months ago (2017-04-05 13:23:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800703002/1
3 years, 8 months ago (2017-04-05 13:27:02 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 14:02:50 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f2878c09d532945c3ffbe6f0386d...

Powered by Google App Engine
This is Rietveld 408576698