Introduce PendingScript::startStreamingIfPossible()

Introduce PendingScript::startStreamingIfPossible()

This is preparation for introducing ModulePendingScript.

As TaskType::Networking uses the loading task runner in the back,
this CL shouldn't change any behavior.

BUG=594639, 686281
Review-Url: https://codereview.chromium.org/2800683005
Cr-Commit-Position: refs/heads/master@{#462353}
Committed: https://chromium.googlesource.com/chromium/src/+/ab145489a36b45789323b50bcaceab843423ec06

[hiroshige, 2017-04-05 22:17:48]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 22:18:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2017-04-05 22:30:29]

hiroshige@chromium.org changed reviewers:
+ haraken@chromium.org, kouhei@chromium.org, marja@chromium.org

[hiroshige, 2017-04-05 22:30:29]

PTAL.

Question about the task runner:

There are three call sites of startStreaming():
(a) two of them uses the TaskType::Networking task runner and
(b) the other one uses loadingTaskRunner().

haraken@, you changed (a) to use Networking task runner in
https://codereview.chromium.org/2224923002.
Is (b) intentionally left using loadingTaskRunner()?
(I assume No and the current patch set uses Networking task runner for all
callsites)

[hiroshige, 2017-04-05 23:01:03]

Description was changed from

==========
Introduce PendingScript::startStreamingIfPossible()

BUG=
==========

to

==========
Introduce PendingScript::startStreamingIfPossible()

BUG=594639
==========

[hiroshige, 2017-04-05 23:01:33]

Description was changed from

==========
Introduce PendingScript::startStreamingIfPossible()

BUG=594639
==========

to

==========
Introduce PendingScript::startStreamingIfPossible()

BUG=594639, 686281
==========

[hiroshige, 2017-04-05 23:02:43]

Description was changed from

==========
Introduce PendingScript::startStreamingIfPossible()

BUG=594639, 686281
==========

to

==========
Introduce PendingScript::startStreamingIfPossible()

This is preparation for introducing ModulePendingScript.

BUG=594639, 686281
==========

[commit-bot: I haz the power, 2017-04-06 00:31:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 00:31:01]

Dry run: This issue passed the CQ dry run.

[haraken, 2017-04-06 01:28:44]

On 2017/04/05 22:30:29, hiroshige wrote:
> PTAL.
> 
> Question about the task runner:
> 
> There are three call sites of startStreaming():
> (a) two of them uses the TaskType::Networking task runner and
> (b) the other one uses loadingTaskRunner().
> 
> haraken@, you changed (a) to use Networking task runner in
> https://codereview.chromium.org/2224923002.
> Is (b) intentionally left using loadingTaskRunner()?
> (I assume No and the current patch set uses Networking task runner for all
> callsites)

LGTM

You're right. We should use TaskType::Networking. TaskType::Networking is using
the loading task runner in the back, so this CL won't change any behavior.

[kouhei (in TOK), 2017-04-06 01:44:00]

lgtm

[hiroshige, 2017-04-06 03:03:41]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 03:03:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2017-04-06 03:04:28]

Description was changed from

==========
Introduce PendingScript::startStreamingIfPossible()

This is preparation for introducing ModulePendingScript.

BUG=594639, 686281
==========

to

==========
Introduce PendingScript::startStreamingIfPossible()

This is preparation for introducing ModulePendingScript.

As TaskType::Networking uses the loading task runner in the back,
this CL shouldn't change any behavior.

BUG=594639, 686281
==========

[hiroshige, 2017-04-06 03:05:14]

The CQ bit was unchecked by hiroshige@chromium.org

[hiroshige, 2017-04-06 03:13:25]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2017-04-06 03:13:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, kouhei@chromium.org
Link to the patchset: https://codereview.chromium.org/2800683005/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-06 03:13:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 04:24:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491448405127670,
"parent_rev": "e7244833f87207408c4c571b96c0f155d417898c", "commit_rev":
"ab145489a36b45789323b50bcaceab843423ec06"}

[commit-bot: I haz the power, 2017-04-06 04:26:07]

Description was changed from

==========
Introduce PendingScript::startStreamingIfPossible()

This is preparation for introducing ModulePendingScript.

As TaskType::Networking uses the loading task runner in the back,
this CL shouldn't change any behavior.

BUG=594639, 686281
==========

to

==========
Introduce PendingScript::startStreamingIfPossible()

This is preparation for introducing ModulePendingScript.

As TaskType::Networking uses the loading task runner in the back,
this CL shouldn't change any behavior.

BUG=594639, 686281

Review-Url: https://codereview.chromium.org/2800683005
Cr-Commit-Position: refs/heads/master@{#462353}
Committed:
https://chromium.googlesource.com/chromium/src/+/ab145489a36b45789323b50bcace...
==========

[commit-bot: I haz the power, 2017-04-06 04:26:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ab145489a36b45789323b50bcace...