Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2800683004: Fix and update QUIC connection close enums in histograms.xml (Closed)

Created:
3 years, 8 months ago by Zhongyi Shi
Modified:
3 years, 8 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, Ryan Hamilton
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix and update QUIC connection close enums in histograms.xml BUG= Review-Url: https://codereview.chromium.org/2800683004 Cr-Commit-Position: refs/heads/master@{#462656} Committed: https://chromium.googlesource.com/chromium/src/+/11478559514163d8c3c9d0899bfb9ee536876383

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -1 line 1 comment Download

Messages

Total messages: 14 (5 generated)
Zhongyi Shi
3 years, 8 months ago (2017-04-05 21:35:33 UTC) #2
Buck
lgtm
3 years, 8 months ago (2017-04-05 21:37:01 UTC) #3
Ryan Hamilton
LGTM
3 years, 8 months ago (2017-04-05 22:14:35 UTC) #5
Zhongyi Shi
Alexei, ptal, thanks!
3 years, 8 months ago (2017-04-05 22:46:33 UTC) #6
Zhongyi Shi
asvitkine@: friendly ping!
3 years, 8 months ago (2017-04-06 21:12:52 UTC) #7
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/2800683004/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2800683004/diff/1/tools/metrics/histograms/histograms.xml#oldcode108218 tools/metrics/histograms/histograms.xml:108218: - <int value="95" label="HEADERS_STREAM_DATA_DECOMPRESS_FAILURE"/> Was this always wrongly ...
3 years, 8 months ago (2017-04-06 21:14:24 UTC) #8
Zhongyi Shi
On 2017/04/06 21:14:24, Alexei Svitkine (slow) wrote: > lgtm > > https://codereview.chromium.org/2800683004/diff/1/tools/metrics/histograms/histograms.xml > File tools/metrics/histograms/histograms.xml ...
3 years, 8 months ago (2017-04-06 21:19:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800683004/1
3 years, 8 months ago (2017-04-06 21:21:10 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 22:38:33 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/11478559514163d8c3c9d0899bfb...

Powered by Google App Engine
This is Rietveld 408576698