Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2800683003: Workaround for Samsung email issues (Closed)

Created:
3 years, 8 months ago by Changwan Ryu
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, sof, creis+watch_chromium.org, kinuko+watch, eae+blinkwatch, nasko+codewatch_chromium.org, jam, blink-reviews-api_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, darin-cc_chromium.org, agrieve+watch_chromium.org, blink-reviews, blink-reviews-frames_chromium.org, android-webview-reviews_chromium.org, rwlbuis
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Workaround for Samsung email issues Samsung's email works around Range.getClientRects()'s behavior to return an empty sequence for a collapsed range, and the workaround is to insert a non-zero space, and call Range.getClientRects(), and then remove the non-zero space. With the changes introduced in https://codereview.chromium.org/2687273002, now inserting a non-zero space triggers a selectionchanged event and it causes an infinite loop, leading to issues with scroll, caret blink, and paste. Because it is difficult for Samsung to update their email any time soon, we undo the above changes only for WebView by adding a runtime flag and set it. The rationale for generalizing this to WebView is: 1) Package name checks generally don't work very well - there may be variants for different devices or beta channels. 2) JS library developers should still be concerned about out-of-date WebView libraries anyways. This should be fixed for version N and above, so we limit the workaround to Android M and below. BUG=698752, 699943 Review-Url: https://codereview.chromium.org/2776073002 Cr-Commit-Position: refs/heads/master@{#462173} (cherry picked from commit e54ccdb9fbd84362cba3c5858deaad215e572f5c) Review-Url: https://codereview.chromium.org/2800683003 . Cr-Commit-Position: refs/branch-heads/3029@{#594} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/deb6d19e2d5be3f8f13fcefdaf20a67743bcc207

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -19 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java View 1 chunk +8 lines, -4 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwSettings.java View 4 chunks +13 lines, -5 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java View 3 chunks +101 lines, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java View 1 chunk +2 lines, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java View 1 chunk +2 lines, -1 line 0 comments Download
M android_webview/native/aw_settings.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java View 1 chunk +5 lines, -4 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/web_preferences.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/public/common/web_preferences.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Range.cpp View 2 chunks +8 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Settings.json5 View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebSettings.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Changwan Ryu
3 years, 8 months ago (2017-04-05 20:52:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
deb6d19e2d5be3f8f13fcefdaf20a67743bcc207.

Powered by Google App Engine
This is Rietveld 408576698