Switch run_isolated.py to use a constant path 'ir'.

Switch run_isolated.py to use a constant path 'ir'.

This means that for a Swarming bot running at /b/s, the run dir root will be
/b/s/w/ir/.

The output and temporary directories remain random.

All a variable to map_and_run() in run_isolated.py, as maybe it could be made a
task option (?) Still undecided.

R=nodir@chromium.org
BUG=697759
Review-Url: https://codereview.chromium.org/2800643003
Committed: https://github.com/luci/luci-py/commit/15283a543acb4912643539215968f04fbc4f7e02

[M-A Ruel, 2017-04-05 18:45:20]

I didn't surface the flag at the CLI level yet as I don't know if it's valuable.

[nodir, 2017-04-06 22:58:16]

lgtm

https://codereview.chromium.org/2800643003/diff/1/client/run_isolated.py
File client/run_isolated.py (right):

https://codereview.chromium.org/2800643003/diff/1/client/run_isolated.py#newc...
client/run_isolated.py:406: install_packages_fn, use_symlinks, constant_path):
this name is generic and does not necessarily mean that this is about rundir

https://codereview.chromium.org/2800643003/diff/1/client/run_isolated.py#newc...
client/run_isolated.py:456: # If root_dir is not specified, it is not constant.
maybe return an error if constant_path is True, but root_dir is not?
currently it is rather unobvious. if root_dir is not set, but cache_dir is set,
then rundir will be constant

[M-A Ruel, 2017-04-07 15:36:33]

https://codereview.chromium.org/2800643003/diff/1/client/run_isolated.py
File client/run_isolated.py (right):

https://codereview.chromium.org/2800643003/diff/1/client/run_isolated.py#newc...
client/run_isolated.py:406: install_packages_fn, use_symlinks, constant_path):
On 2017/04/06 22:58:16, nodir wrote:
> this name is generic and does not necessarily mean that this is about rundir

Changed to constant_run_path.

https://codereview.chromium.org/2800643003/diff/1/client/run_isolated.py#newc...
client/run_isolated.py:456: # If root_dir is not specified, it is not constant.
On 2017/04/06 22:58:16, nodir wrote:
> maybe return an error if constant_path is True, but root_dir is not?
> currently it is rather unobvious. if root_dir is not set, but cache_dir is
set,
> then rundir will be constant

Not done yet because constant_run_path is hard coded to True. I added a TODO and
will revisit if there's a need.

[M-A Ruel, 2017-04-07 15:36:38]

The CQ bit was checked by maruel@chromium.org

[M-A Ruel, 2017-04-07 15:36:39]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/2800643003/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2017-04-07 15:36:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 15:39:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491579398729450,
"parent_rev": "23f369607252c4d23b7cf2ac74df96c2ca2f4372", "commit_rev":
"15283a543acb4912643539215968f04fbc4f7e02"}

[commit-bot: I haz the power, 2017-04-07 15:39:27]

Description was changed from

==========
Switch run_isolated.py to use a constant path 'ir'.

This means that for a Swarming bot running at /b/s, the run dir root will be
/b/s/w/ir/.

The output and temporary directories remain random.

All a variable to map_and_run() in run_isolated.py, as maybe it could be made a
task option (?) Still undecided.

R=nodir@chromium.org
BUG=697759
==========

to

==========
Switch run_isolated.py to use a constant path 'ir'.

This means that for a Swarming bot running at /b/s, the run dir root will be
/b/s/w/ir/.

The output and temporary directories remain random.

All a variable to map_and_run() in run_isolated.py, as maybe it could be made a
task option (?) Still undecided.

R=nodir@chromium.org
BUG=697759

Review-Url: https://codereview.chromium.org/2800643003
Committed:
https://github.com/luci/luci-py/commit/15283a543acb4912643539215968f04fbc4f7e02
==========

[commit-bot: I haz the power, 2017-04-07 15:39:28]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/15283a543acb4912643539215968f04fbc4f7e02