Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: tools/buildbot/perf/dashboard/ui/generic_plotter.html

Issue 28006: Sort revision numebrs numerically rather than alphabetically.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/buildbot/perf/dashboard/ui/generic_plotter.html
===================================================================
--- tools/buildbot/perf/dashboard/ui/generic_plotter.html (revision 10124)
+++ tools/buildbot/perf/dashboard/ui/generic_plotter.html (working copy)
@@ -243,11 +243,12 @@
traceNames.push(traceName);
traceNames.sort(trace_compare);
- // Build and sort a list of revision numbers.
+ // Build and numerically sort a list of revision numbers.
var revisionNumbers = [];
for (var rev in graphData)
revisionNumbers.push(rev);
- revisionNumbers.sort();
+ revisionNumbers.sort(
+ function(a, b) { return parseInt(a, 10) - parseInt(b, 10) });
// Build separate ordered lists of trace data.
var traceData = {};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698