Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Side by Side Diff: tools/buildbot/perf/dashboard/ui/generic_plotter.html

Issue 28006: Sort revision numebrs numerically rather than alphabetically.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <html> 1 <html>
2 2
3 <!-- 3 <!--
4 Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 4 Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
5 Use of this source code is governed by a BSD-style license that can be 5 Use of this source code is governed by a BSD-style license that can be
6 found in the LICENSE file. 6 found in the LICENSE file.
7 --> 7 -->
8 8
9 <!-- 9 <!--
10 A brief note on terminology as used here: a "graph" is a plotted screenful 10 A brief note on terminology as used here: a "graph" is a plotted screenful
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 return 1; 236 return 1;
237 return compare(name1, name2); 237 return compare(name1, name2);
238 } 238 }
239 239
240 // Build and sort a list of all the trace names we've seen. 240 // Build and sort a list of all the trace names we've seen.
241 var traceNames = []; 241 var traceNames = [];
242 for (var traceName in allTraces) 242 for (var traceName in allTraces)
243 traceNames.push(traceName); 243 traceNames.push(traceName);
244 traceNames.sort(trace_compare); 244 traceNames.sort(trace_compare);
245 245
246 // Build and sort a list of revision numbers. 246 // Build and numerically sort a list of revision numbers.
247 var revisionNumbers = []; 247 var revisionNumbers = [];
248 for (var rev in graphData) 248 for (var rev in graphData)
249 revisionNumbers.push(rev); 249 revisionNumbers.push(rev);
250 revisionNumbers.sort(); 250 revisionNumbers.sort(
251 function(a, b) { return parseInt(a, 10) - parseInt(b, 10) });
251 252
252 // Build separate ordered lists of trace data. 253 // Build separate ordered lists of trace data.
253 var traceData = {}; 254 var traceData = {};
254 for (var revIndex = 0; revIndex < revisionNumbers.length; ++revIndex) { 255 for (var revIndex = 0; revIndex < revisionNumbers.length; ++revIndex) {
255 var rev = revisionNumbers[revIndex]; 256 var rev = revisionNumbers[revIndex];
256 var revisionData = graphData[rev]; 257 var revisionData = graphData[rev];
257 for (var nameIndex = 0; nameIndex < traceNames.length; ++nameIndex) { 258 for (var nameIndex = 0; nameIndex < traceNames.length; ++nameIndex) {
258 var traceName = traceNames[nameIndex]; 259 var traceName = traceNames[nameIndex];
259 if (!traceData[traceName]) 260 if (!traceData[traceName])
260 traceData[traceName] = []; 261 traceData[traceName] = [];
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
396 details.style.display = "none"; 397 details.style.display = "none";
397 header_text.style.display = "none"; 398 header_text.style.display = "none";
398 explain.style.display = "none"; 399 explain.style.display = "none";
399 selection.style.display = "none"; 400 selection.style.display = "none";
400 } else { 401 } else {
401 document.getElementById("header_lookout").style.display = "none"; 402 document.getElementById("header_lookout").style.display = "none";
402 } 403 }
403 </script> 404 </script>
404 </body> 405 </body>
405 </html> 406 </html>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698