DevTools: editing property values should wrap object literals similar to console

DevTools: editing property values should wrap object literals similar to console

When editing a property value in an ObjPropSection (double click the value), we
should be wrapping object literals the same way that console does:
'{}' becomes '({})'.

BUG=616611
Review-Url: https://codereview.chromium.org/2800573002
Cr-Commit-Position: refs/heads/master@{#466077}
Committed: https://chromium.googlesource.com/chromium/src/+/f4ecb9e37e9e2d59e32b8b96f23ac4a1e33b9552

[luoe, 2017-04-05 01:17:12]

Description was changed from

==========
DevTools: editing property values should wrap object literals similar to console

BUG=616611
==========

to

==========
DevTools: editing property values should wrap object literals similar to console

When editing a property value in an ObjPropSection (double click the value), we
should be wrapping object literals the same way that console does:
'{}' becomes '({})'.

BUG=616611
==========

[luoe, 2017-04-05 01:17:17]

luoe@chromium.org changed reviewers:
+ lushnikov@chromium.org

[luoe, 2017-04-05 01:17:17]

Moving a common utility used in the console so that ObjectPropertiesSection can
use it.  I don't think the location is perfect, but SDK.RuntimeModel is related
to runtime evaluations and is common to both clients.

[lushnikov, 2017-04-08 00:10:40]

lushnikov@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org

[lushnikov, 2017-04-08 00:11:09]

https://codereview.chromium.org/2800573002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js
(right):

https://codereview.chromium.org/2800573002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js:891:
expression =
SDK.RuntimeModel.wrapObjectLiteralExpressionIfNeeded(expression.trim());
why can't we always surround with parentheses? + @kozy who should know the
answer!

[lushnikov, 2017-04-11 23:58:14]

code looks good, though I'm not sure that RuntimeModel is the best place for the
convenience method. @kozy, do you have a better place for this?

[kozy, 2017-04-20 00:17:20]

It looks like utils method but we don't have utils file for sdk module, so let's
put it in RuntimeModel for now.

lgtm.

https://codereview.chromium.org/2800573002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js
(right):

https://codereview.chromium.org/2800573002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js:891:
expression =
SDK.RuntimeModel.wrapObjectLiteralExpressionIfNeeded(expression.trim());
On 2017/04/08 00:11:09, lushnikov wrote:
> why can't we always surround with parentheses? + @kozy who should know the
> answer!

it changes semantic.

[lushnikov, 2017-04-20 03:02:43]

lgtm

[luoe, 2017-04-20 16:46:30]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2017-04-20 16:47:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 18:21:56]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492706790628180, "parent_rev":
"de974cb345c5cd4664b669ab2b0b961bb3c75469", "commit_rev":
"f4ecb9e37e9e2d59e32b8b96f23ac4a1e33b9552"}

[commit-bot: I haz the power, 2017-04-20 18:22:03]

Description was changed from

==========
DevTools: editing property values should wrap object literals similar to console

When editing a property value in an ObjPropSection (double click the value), we
should be wrapping object literals the same way that console does:
'{}' becomes '({})'.

BUG=616611
==========

to

==========
DevTools: editing property values should wrap object literals similar to console

When editing a property value in an ObjPropSection (double click the value), we
should be wrapping object literals the same way that console does:
'{}' becomes '({})'.

BUG=616611

Review-Url: https://codereview.chromium.org/2800573002
Cr-Commit-Position: refs/heads/master@{#466077}
Committed:
https://chromium.googlesource.com/chromium/src/+/f4ecb9e37e9e2d59e32b8b96f23a...
==========

[commit-bot: I haz the power, 2017-04-20 18:22:05]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f4ecb9e37e9e2d59e32b8b96f23a...