Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2800563002:
Add page_info_strings.grdp to the page_info watchlist. (Closed)
DescriptionAdd page_info_strings.grdp to the page_info watchlist.
BUG=661799
Review-Url: https://codereview.chromium.org/2800563002
Cr-Commit-Position: refs/heads/master@{#462967}
Committed: https://chromium.googlesource.com/chromium/src/+/6cd116a5bd21185f22e6231c8b048d898f7119c2
Patch Set 1 : Add page_info_strings.grdp to the page_info watchlist. #Patch Set 2 : Fix indentation. #Messages
Total messages: 19 (13 generated)
Description was changed from ========== Add page_info_strings.grdp to the page_info watchlist. Rename pageinfo_strings.grdp to page_info_strings.grdp BUG=661799 ========== to ========== Add page_info_strings.grdp to the page_info watchlist. BUG=661799 ==========
lgarron@chromium.org changed reviewers: + raymes@chromium.org
raymes@, could you review?
The CQ bit was checked by lgarron@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm - but I'm not sure if you saw my question previously. Do you know why we get cc'd on https://codereview.chromium.org/2767163003/ ? I couldn't figure out how the watchlists applied to that CL.
The CQ bit was checked by lgarron@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by lgarron@chromium.org
I have no idea why we're CCed there. :-( The only other auto-CC there is derat@, who actually matches a rule correctly.
The CQ bit was checked by lgarron@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org Link to the patchset: https://codereview.chromium.org/2800563002/#ps40001 (title: "Fix indentation.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491591799436520,
"parent_rev": "7dbbea4c0d8e6f34a12ab7ce3b4a92d36e25d2f8", "commit_rev":
"6cd116a5bd21185f22e6231c8b048d898f7119c2"}
Message was sent while issue was closed.
Description was changed from ========== Add page_info_strings.grdp to the page_info watchlist. BUG=661799 ========== to ========== Add page_info_strings.grdp to the page_info watchlist. BUG=661799 Review-Url: https://codereview.chromium.org/2800563002 Cr-Commit-Position: refs/heads/master@{#462967} Committed: https://chromium.googlesource.com/chromium/src/+/6cd116a5bd21185f22e6231c8b04... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/6cd116a5bd21185f22e6231c8b04... |
