Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 2800533002: Remove unnecessary v8.h include from chrome/browser/. (Closed)

Created:
3 years, 8 months ago by jbroman
Modified:
3 years, 8 months ago
CC:
chromium-reviews, davemoore+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary v8.h include from chrome/browser/. Review-Url: https://codereview.chromium.org/2800533002 Cr-Commit-Position: refs/heads/master@{#462501} Committed: https://chromium.googlesource.com/chromium/src/+/4c1167f3e7504dd69fa347eaa5619384b2be857e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/voice_search_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
jbroman
This dependency seems unnecessary.
3 years, 8 months ago (2017-04-05 14:40:24 UTC) #6
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-04-06 10:00:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800533002/1
3 years, 8 months ago (2017-04-06 13:27:03 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 16:02:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4c1167f3e7504dd69fa347eaa561...

Powered by Google App Engine
This is Rietveld 408576698