Omnibox Metrics - Rename MobileOmniboxClipboardChanged

Omnibox Metrics - Rename MobileOmniboxClipboardChanged

to MobileClipboardChanged.  (Mark the old one as obsolete; make myself one of the owners of the new one.)

After all, the code to watch for this has nothing directly to do with
the omnibox or an "omnibox clipboard".

BUG=704715
Review-Url: https://codereview.chromium.org/2800483002
Cr-Commit-Position: refs/heads/master@{#462402}
Committed: https://chromium.googlesource.com/chromium/src/+/4a49ce9b7bfe546a90e6f3ccc2b6c34de764463c

[Mark P, 2017-04-04 21:51:06]

Description was changed from

==========
Omnibox Metrics - Rename MobileOmniboxClipboardChanged

to MobileClipboardChanged

After all, the code to watch for this has nothing directly to do with
the omnibox or an "omnibox clipboard".

BUG=704715
==========

to

==========
Omnibox Metrics - Rename MobileOmniboxClipboardChanged

to MobileClipboardChanged.  (Mark the old one as obsolete; make myself one of
the owners of the new one.)

After all, the code to watch for this has nothing directly to do with
the omnibox or an "omnibox clipboard".

BUG=704715
==========

[Mark P, 2017-04-04 21:52:27]

The CQ bit was checked by mpearson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 21:52:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark P, 2017-04-04 21:53:02]

mpearson@chromium.org changed reviewers:
+ jif@chromium.org

[Mark P, 2017-04-04 21:53:03]

jif@, could you please review this simple change?

thanks,
mark

[commit-bot: I haz the power, 2017-04-04 22:09:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 22:09:13]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jif, 2017-04-05 13:52:49]

https://codereview.chromium.org/2800483002/diff/20001/tools/metrics/actions/a...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/2800483002/diff/20001/tools/metrics/actions/a...
tools/metrics/actions/actions.xml:9534: that the content of the clipboard
changed, or when the clipboard changes
While you are here, can you update the description of the iOS part?
The semantic of that metric changed because of a bug in iOS10 (
crbug.com/628592).

Can you update the description to something like:

On iOS: this occurs either when Chrome enters the foreground and notices that
the content of the clipboard changed, or when the users selects the omnibox and
Chrome notices that the content of the clipboard changed.

[Mark P, 2017-04-05 19:10:27]

https://codereview.chromium.org/2800483002/diff/20001/tools/metrics/actions/a...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/2800483002/diff/20001/tools/metrics/actions/a...
tools/metrics/actions/actions.xml:9534: that the content of the clipboard
changed, or when the clipboard changes
On 2017/04/05 13:52:48, jif wrote:
> While you are here, can you update the description of the iOS part?
> The semantic of that metric changed because of a bug in iOS10 (
> crbug.com/628592).
> 
> Can you update the description to something like:
> 
> On iOS: this occurs either when Chrome enters the foreground and notices that
> the content of the clipboard changed, or when the users selects the omnibox
and
> Chrome notices that the content of the clipboard changed.

Done.  (Took your suggestion verbatim.)

[jif-google, 2017-04-05 20:50:44]

jif@google.com changed reviewers:
+ jif@google.com

[jif-google, 2017-04-05 20:50:45]

Thank you.

lgtm

[Mark P, 2017-04-05 21:47:59]

mpearson@chromium.org changed reviewers:
+ isherman@chromium.org, tedchoc@chromium.org

[Mark P, 2017-04-05 21:48:00]

tedchoc@, can you approve the change to Clipboard.java?
isherman@, can you approve the change to actions.xml?

thanks all.

[Ilya Sherman, 2017-04-05 21:50:32]

https://codereview.chromium.org/2800483002/diff/60001/tools/metrics/actions/a...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/2800483002/diff/60001/tools/metrics/actions/a...
tools/metrics/actions/actions.xml:9531: Emitted when Chrome detects that the
clipboard contains a new URL.
Is this specifically only emitted when the clipboard contents are a URL, or when
the string changes for any reason?

[Mark P, 2017-04-05 22:03:28]

https://codereview.chromium.org/2800483002/diff/60001/tools/metrics/actions/a...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/2800483002/diff/60001/tools/metrics/actions/a...
tools/metrics/actions/actions.xml:9531: Emitted when Chrome detects that the
clipboard contains a new URL.
On 2017/04/05 21:50:32, Ilya Sherman wrote:
> Is this specifically only emitted when the clipboard contents are a URL, or
when
> the string changes for any reason?

Any contents.  Good catch!  Revised description.

[Ilya Sherman, 2017-04-05 22:56:24]

LGTM, thakns.

[Ted C, 2017-04-05 23:04:12]

lgtm

[Mark P, 2017-04-05 23:09:29]

The CQ bit was checked by mpearson@chromium.org

[Mark P, 2017-04-05 23:09:30]

The patchset sent to the CQ was uploaded after l-g-t-m from jif@google.com
Link to the patchset: https://codereview.chromium.org/2800483002/#ps80001
(title: "revise description")

[commit-bot: I haz the power, 2017-04-05 23:10:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 23:36:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 23:36:17]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mark P, 2017-04-05 23:44:33]

jif@,

Can you please approve this as yourself, not as jif-google@??  The latter
doesn't pass the presubmit OWNERS test.

Feel free to CQ this after you approve it properly.

thanks,
mark

[jif, 2017-04-06 09:23:01]

The CQ bit was checked by jif@chromium.org

[jif, 2017-04-06 09:23:01]

lgtm

[commit-bot: I haz the power, 2017-04-06 09:23:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 09:30:02]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491470581241480,
"parent_rev": "1392ff9f43c86c539e53e698674693ef11c029da", "commit_rev":
"4a49ce9b7bfe546a90e6f3ccc2b6c34de764463c"}

[commit-bot: I haz the power, 2017-04-06 09:30:53]

Description was changed from

==========
Omnibox Metrics - Rename MobileOmniboxClipboardChanged

to MobileClipboardChanged.  (Mark the old one as obsolete; make myself one of
the owners of the new one.)

After all, the code to watch for this has nothing directly to do with
the omnibox or an "omnibox clipboard".

BUG=704715
==========

to

==========
Omnibox Metrics - Rename MobileOmniboxClipboardChanged

to MobileClipboardChanged.  (Mark the old one as obsolete; make myself one of
the owners of the new one.)

After all, the code to watch for this has nothing directly to do with
the omnibox or an "omnibox clipboard".

BUG=704715

Review-Url: https://codereview.chromium.org/2800483002
Cr-Commit-Position: refs/heads/master@{#462402}
Committed:
https://chromium.googlesource.com/chromium/src/+/4a49ce9b7bfe546a90e6f3ccc2b6...
==========

[commit-bot: I haz the power, 2017-04-06 09:30:54]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/4a49ce9b7bfe546a90e6f3ccc2b6...