Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 2800393002: Do not build type1, type1cid and psaux FreeType modules on Android (Closed)

Created:
3 years, 8 months ago by drott
Modified:
3 years, 8 months ago
Reviewers:
bungeman-chromium, eae
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not build type1, type1cid and psaux FreeType modules on Android In 27b5c368e1cd8535b26aacc593e544e18d04d29f we added three additional FreeType modules required by PDFium on desktop. Since we do not build PDFium for Android we do not need to build those modules for the Android platform and can save on binary size. BUG=707782 Review-Url: https://codereview.chromium.org/2800393002 Cr-Commit-Position: refs/heads/master@{#463219} Committed: https://chromium.googlesource.com/chromium/src/+/945c459ee86d70a798af66346f7025453d9b16cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -7 lines) Patch
M third_party/freetype/BUILD.gn View 3 chunks +14 lines, -4 lines 0 comments Download
M third_party/freetype/include/freetype-custom-config/ftmodule.h View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
drott
3 years, 8 months ago (2017-04-10 07:37:57 UTC) #4
eae
LGTM
3 years, 8 months ago (2017-04-10 07:42:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800393002/1
3 years, 8 months ago (2017-04-10 11:19:06 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 11:24:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/945c459ee86d70a798af66346f70...

Powered by Google App Engine
This is Rietveld 408576698