Stop blocking the mousedown event of left click when closing context menu.

Stop blocking the mousedown event of left click when closing context menu.

This change will enable to choose a file and close a context menu
simultaneously by a single click in the file list of the Files app.

Before this change, only the mousedown event of a left click which
dismisses the context menu of cr.ui was blocked its propagation.
It was introduced by https://codereview.chromium.org/1431103003,
which was been directed to 487194 and 507681.
This change will partially remove the change made by that, however,
I think Issue 507681 was resolved by the change to apps_page.js, and
487194 was done by that of title_page.js in the original change.
I confirmed that the both issues doesn't reappear by this change.

BUG=679982
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2800383002
Cr-Commit-Position: refs/heads/master@{#464285}
Committed: https://chromium.googlesource.com/chromium/src/+/3ce9680f3fb4648e3d1ff964f25648eb01fcb579

[yamaguchi, 2017-04-10 07:16:09]

Description was changed from

==========
Stop blocking the left mouse up event when closing the context menu.

BUG=679982
==========

to

==========
Stop blocking the left mouse up event when closing the context menu.

BUG=679982
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yamaguchi, 2017-04-10 08:31:11]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 08:31:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2017-04-10 08:45:56]

Description was changed from

==========
Stop blocking the left mouse up event when closing the context menu.

BUG=679982
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Stop blocking the mouse-up event of the left click when closing context menu.

This change will enable choosing a file by left-click and closing the context
menu simultaneously in the Files app.

Before this change, only the mouseup event of a left click which dismisses the
context menu of cr.ui was blocked its propagation.
It was introduced by https://codereview.chromium.org/1431103003,
which was been directed to 487194 and 507681.
This change will partially remove the change made by that, however, Issue 507681
would have been resolved by the change to apps_page.js, and 487194 would have
been done by that of title_page.js in the original change.

BUG=679982
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yamaguchi, 2017-04-10 08:50:00]

Description was changed from

==========
Stop blocking the mouse-up event of the left click when closing context menu.

This change will enable choosing a file by left-click and closing the context
menu simultaneously in the Files app.

Before this change, only the mouseup event of a left click which dismisses the
context menu of cr.ui was blocked its propagation.
It was introduced by https://codereview.chromium.org/1431103003,
which was been directed to 487194 and 507681.
This change will partially remove the change made by that, however, Issue 507681
would have been resolved by the change to apps_page.js, and 487194 would have
been done by that of title_page.js in the original change.

BUG=679982
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Stop blocking the mouse-up event of left click when closing context menu.

This change will enable choosing a file by left-click and closing the
context menu simultaneously in the Files app.

Before this change, only the mouseup event of a left click which
dismisses the context menu of cr.ui was blocked its propagation.
It was introduced by https://codereview.chromium.org/1431103003,
which was been directed to 487194 and 507681.
This change will partially remove the change made by that, however,
Issue 507681 would have been resolved by the change to apps_page.js, and 487194
would have been done by that of title_page.js in the
original change.

BUG=679982
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yamaguchi, 2017-04-10 08:50:23]

Description was changed from

==========
Stop blocking the mouse-up event of left click when closing context menu.

This change will enable choosing a file by left-click and closing the
context menu simultaneously in the Files app.

Before this change, only the mouseup event of a left click which
dismisses the context menu of cr.ui was blocked its propagation.
It was introduced by https://codereview.chromium.org/1431103003,
which was been directed to 487194 and 507681.
This change will partially remove the change made by that, however,
Issue 507681 would have been resolved by the change to apps_page.js, and 487194
would have been done by that of title_page.js in the
original change.

BUG=679982
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Stop blocking the mouse-up event of left click when closing context menu.

This change will enable choosing a file by left-click and closing the
context menu simultaneously in the Files app.

Before this change, only the mouseup event of a left click which
dismisses the context menu of cr.ui was blocked its propagation.
It was introduced by https://codereview.chromium.org/1431103003,
which was been directed to 487194 and 507681.
This change will partially remove the change made by that, however,
Issue 507681 would have been resolved by the change to apps_page.js,
and 487194 would have been done by that of title_page.js in the
original change.

BUG=679982
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yamaguchi, 2017-04-10 09:49:51]

Description was changed from

==========
Stop blocking the mouse-up event of left click when closing context menu.

This change will enable choosing a file by left-click and closing the
context menu simultaneously in the Files app.

Before this change, only the mouseup event of a left click which
dismisses the context menu of cr.ui was blocked its propagation.
It was introduced by https://codereview.chromium.org/1431103003,
which was been directed to 487194 and 507681.
This change will partially remove the change made by that, however,
Issue 507681 would have been resolved by the change to apps_page.js,
and 487194 would have been done by that of title_page.js in the
original change.

BUG=679982
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Stop blocking the mouse-up event of left click when closing context menu.

This change will enable to choose a file and close a context menu
simultaneously by a single click in the file list of the Files app.

Before this change, only the mouseup event of a left click which
dismisses the context menu of cr.ui was blocked its propagation.
It was introduced by https://codereview.chromium.org/1431103003,
which was been directed to 487194 and 507681.
This change will partially remove the change made by that, however,
Issue 507681 would have been resolved by the change to apps_page.js,
and 487194 would have been done by that of title_page.js in the
original change.

BUG=679982
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yamaguchi, 2017-04-10 09:54:51]

yamaguchi@chromium.org changed reviewers:
+ fukino@chromium.org

[yamaguchi, 2017-04-10 09:54:52]

To fukino:
Will you review this so as to make sure this will fix the issue in Files?
I'll be sending this review to OWNERS of ui/webui after it.

[commit-bot: I haz the power, 2017-04-10 10:29:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 10:29:01]

Dry run: This issue passed the CQ dry run.

[yamaguchi, 2017-04-11 01:19:54]

Description was changed from

==========
Stop blocking the mouse-up event of left click when closing context menu.

This change will enable to choose a file and close a context menu
simultaneously by a single click in the file list of the Files app.

Before this change, only the mouseup event of a left click which
dismisses the context menu of cr.ui was blocked its propagation.
It was introduced by https://codereview.chromium.org/1431103003,
which was been directed to 487194 and 507681.
This change will partially remove the change made by that, however,
Issue 507681 would have been resolved by the change to apps_page.js,
and 487194 would have been done by that of title_page.js in the
original change.

BUG=679982
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Stop blocking the mousedown event of left click when closing context menu.

This change will enable to choose a file and close a context menu
simultaneously by a single click in the file list of the Files app.

Before this change, only the mousedown event of a left click which
dismisses the context menu of cr.ui was blocked its propagation.
It was introduced by https://codereview.chromium.org/1431103003,
which was been directed to 487194 and 507681.
This change will partially remove the change made by that, however,
Issue 507681 would have been resolved by the change to apps_page.js,
and 487194 would have been done by that of title_page.js in the
original change.

BUG=679982
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2017-04-11 01:49:02]

lgtm if you confirmed that issue 487194 and 507681 did not reappear.

[yamaguchi, 2017-04-11 01:51:23]

Description was changed from

==========
Stop blocking the mousedown event of left click when closing context menu.

This change will enable to choose a file and close a context menu
simultaneously by a single click in the file list of the Files app.

Before this change, only the mousedown event of a left click which
dismisses the context menu of cr.ui was blocked its propagation.
It was introduced by https://codereview.chromium.org/1431103003,
which was been directed to 487194 and 507681.
This change will partially remove the change made by that, however,
Issue 507681 would have been resolved by the change to apps_page.js,
and 487194 would have been done by that of title_page.js in the
original change.

BUG=679982
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Stop blocking the mousedown event of left click when closing context menu.

This change will enable to choose a file and close a context menu
simultaneously by a single click in the file list of the Files app.

Before this change, only the mousedown event of a left click which
dismisses the context menu of cr.ui was blocked its propagation.
It was introduced by https://codereview.chromium.org/1431103003,
which was been directed to 487194 and 507681.
This change will partially remove the change made by that, however,
I think Issue 507681 was resolved by the change to apps_page.js, and
487194 was done by that of title_page.js in the original change.
I confirmed that the both issue hasn't regressed by this change.

BUG=679982
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yamaguchi, 2017-04-11 01:54:27]

Description was changed from

==========
Stop blocking the mousedown event of left click when closing context menu.

This change will enable to choose a file and close a context menu
simultaneously by a single click in the file list of the Files app.

Before this change, only the mousedown event of a left click which
dismisses the context menu of cr.ui was blocked its propagation.
It was introduced by https://codereview.chromium.org/1431103003,
which was been directed to 487194 and 507681.
This change will partially remove the change made by that, however,
I think Issue 507681 was resolved by the change to apps_page.js, and
487194 was done by that of title_page.js in the original change.
I confirmed that the both issue hasn't regressed by this change.

BUG=679982
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Stop blocking the mousedown event of left click when closing context menu.

This change will enable to choose a file and close a context menu
simultaneously by a single click in the file list of the Files app.

Before this change, only the mousedown event of a left click which
dismisses the context menu of cr.ui was blocked its propagation.
It was introduced by https://codereview.chromium.org/1431103003,
which was been directed to 487194 and 507681.
This change will partially remove the change made by that, however,
I think Issue 507681 was resolved by the change to apps_page.js, and
487194 was done by that of title_page.js in the original change.
I confirmed that the both issues doesn't reappear by this change.

BUG=679982
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yamaguchi, 2017-04-11 02:05:52]

yamaguchi@chromium.org changed reviewers:
+ michaelpg@chromium.org

[yamaguchi, 2017-04-11 02:05:53]

Michael, will you review the change?

[michaelpg, 2017-04-11 22:05:16]

not lgtm

If I understand this change correctly, we normally stop processing left-click
events that close a menu, and this change removes that behavior. So it will
cause left-click events that close a menu to be further processed. This is not
how operating system context menus work, nor is it how the majority of
JavaScript menu toolkits work -- they normally have the same behavior that
handleEvent is currently emulating.

If the Files app wants to select a file on a left click, even when a menu is
open (and closed by that same click), that should be done in the app itself, not
globally in Chrome WebUI.

Please correct me if I'm misunderstanding the effect of this change.

[michaelpg, 2017-04-11 22:09:17]

On 2017/04/11 22:05:16, michaelpg wrote:
> not lgtm
> 
> If I understand this change correctly, we normally stop processing left-click
> events that close a menu, and this change removes that behavior. So it will
> cause left-click events that close a menu to be further processed. This is not
> how operating system context menus work, nor is it how the majority of
> JavaScript menu toolkits work -- they normally have the same behavior that
> handleEvent is currently emulating.


For a reason why this is important, consider what happens after right clicking
and deciding not to select any menu item. How do you close the menu with the
mouse? The normal behavior -- click anywhere outside the menu to close it,
without affecting whatever is clicked on -- is safe and useful, so removing
it makes the UI harder to use and easier to make unwanted changes.

> 
> If the Files app wants to select a file on a left click, even when a menu is
> open (and closed by that same click), that should be done in the app itself,
not
> globally in Chrome WebUI.
> 
> Please correct me if I'm misunderstanding the effect of this change.

[michaelpg, 2017-04-11 23:18:50]

On 2017/04/11 22:09:17, michaelpg wrote:
> On 2017/04/11 22:05:16, michaelpg wrote:
> > not lgtm
> > 
> > If I understand this change correctly, we normally stop processing
left-click
> > events that close a menu, and this change removes that behavior. So it will
> > cause left-click events that close a menu to be further processed. This is
not
> > how operating system context menus work, nor is it how the majority of
> > JavaScript menu toolkits work -- they normally have the same behavior that
> > handleEvent is currently emulating.
> 
> 
> For a reason why this is important, consider what happens after right clicking
> and deciding not to select any menu item. How do you close the menu with the
> mouse? The normal behavior -- click anywhere outside the menu to close it,
> without affecting whatever is clicked on -- is safe and useful, so removing
> it makes the UI harder to use and easier to make unwanted changes.
> 
> > 
> > If the Files app wants to select a file on a left click, even when a menu is
> > open (and closed by that same click), that should be done in the app itself,
> not
> > globally in Chrome WebUI.
> > 
> > Please correct me if I'm misunderstanding the effect of this change.

Huh, just noticed that the behavior I described varies between platforms. On
Chrome OS, we *do* process the mousedown natively, so nothing I said applies.
But on Linux, Chrome doesn't even receive the mousedown event when a native
context menu is open.

I don't know whether we want to go with one decision for all platforms, or
use different logic per platform... but as it stands, some platforms will
behave inconsistently if we hard-code the dismiss logic here or remove it.

dbeam is kinda the focus tsar, so I'll pass the buck to him :-)

[michaelpg, 2017-04-11 23:19:01]

michaelpg@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2017-04-11 23:34:07]

On 2017/04/11 23:18:50, michaelpg wrote:
> On 2017/04/11 22:09:17, michaelpg wrote:
> > On 2017/04/11 22:05:16, michaelpg wrote:
> > > not lgtm
> > > 
> > > If I understand this change correctly, we normally stop processing
> left-click
> > > events that close a menu, and this change removes that behavior. So it
will
> > > cause left-click events that close a menu to be further processed. This is
> not
> > > how operating system context menus work, nor is it how the majority of
> > > JavaScript menu toolkits work -- they normally have the same behavior that
> > > handleEvent is currently emulating.
> > 
> > 
> > For a reason why this is important, consider what happens after right
clicking
> > and deciding not to select any menu item. How do you close the menu with the
> > mouse? The normal behavior -- click anywhere outside the menu to close it,
> > without affecting whatever is clicked on -- is safe and useful, so removing
> > it makes the UI harder to use and easier to make unwanted changes.
> > 
> > > 
> > > If the Files app wants to select a file on a left click, even when a menu
is
> > > open (and closed by that same click), that should be done in the app
itself,
> > not
> > > globally in Chrome WebUI.
> > > 
> > > Please correct me if I'm misunderstanding the effect of this change.
> 
> Huh, just noticed that the behavior I described varies between platforms. On
> Chrome OS, we *do* process the mousedown natively, so nothing I said applies.
> But on Linux, Chrome doesn't even receive the mousedown event when a native
> context menu is open.
> 
> I don't know whether we want to go with one decision for all platforms, or
> use different logic per platform... but as it stands, some platforms will
> behave inconsistently if we hard-code the dismiss logic here or remove it.
> 
> dbeam is kinda the focus tsar, so I'll pass the buck to him :-)

reposting events that close menus is platform-dependent.  i know we do it on
windows.  (cuz I moved the code once:
https://codereview.chromium.org/245993005/).

on Linux, though, generally breaking focus or grab doesn't repost (afaik,
probably depends on various things).
https://cs.chromium.org/chromium/src/ui/views/controls/menu/menu_controller.c...

[Dan Beam, 2017-04-11 23:39:41]

On 2017/04/11 23:18:50, michaelpg wrote:
> On 2017/04/11 22:09:17, michaelpg wrote:
> > On 2017/04/11 22:05:16, michaelpg wrote:
> > > not lgtm
> > > 
> > > If I understand this change correctly, we normally stop processing
> left-click
> > > events that close a menu, and this change removes that behavior. So it
will
> > > cause left-click events that close a menu to be further processed. This is
> not
> > > how operating system context menus work, nor is it how the majority of
> > > JavaScript menu toolkits work -- they normally have the same behavior that
> > > handleEvent is currently emulating.
> > 
> > 
> > For a reason why this is important, consider what happens after right
clicking
> > and deciding not to select any menu item. How do you close the menu with the
> > mouse? The normal behavior -- click anywhere outside the menu to close it,
> > without affecting whatever is clicked on -- is safe and useful, so removing
> > it makes the UI harder to use and easier to make unwanted changes.
> > 
> > > 
> > > If the Files app wants to select a file on a left click, even when a menu
is
> > > open (and closed by that same click), that should be done in the app
itself,
> > not
> > > globally in Chrome WebUI.
> > > 
> > > Please correct me if I'm misunderstanding the effect of this change.
> 
> Huh, just noticed that the behavior I described varies between platforms. On
> Chrome OS, we *do* process the mousedown natively, so nothing I said applies.
> But on Linux, Chrome doesn't even receive the mousedown event when a native
> context menu is open.
> 
> I don't know whether we want to go with one decision for all platforms, or
> use different logic per platform... but as it stands, some platforms will
> behave inconsistently if we hard-code the dismiss logic here or remove it.
> 
> dbeam is kinda the focus tsar, so I'll pass the buck to him :-)

reposting events that close menus is platform-dependent.  i know we do it on
windows.  (cuz I moved the code once:
https://codereview.chromium.org/245993005/).

on Linux, though, closing menu by mousing down outside of menus generally
doesn't repost, so we intentionally don't repost there:
https://cs.chromium.org/chromium/src/ui/views/controls/menu/menu_controller.c...

I think you should probably align with what the platforms do.  Of the places
this code is used a lot (I'm excluding mobile): Windows and ChromeOS repost, Mac
and Linux do not.

[Dan Beam, 2017-04-11 23:43:51]

https://codereview.chromium.org/2800383002/diff/20001/ui/webui/resources/js/c...
File ui/webui/resources/js/cr/ui/context_menu_handler.js (left):

https://codereview.chromium.org/2800383002/diff/20001/ui/webui/resources/js/c...
ui/webui/resources/js/cr/ui/context_menu_handler.js:160: }
please add this code back but do something like this:

switch (e.type) {
  case 'mousedown':
    if (!this.menu.contains(e.target)) {
      this.hideMenu();
      if (e.button == 0 && (cr.isLinux || cr.isMac)) {
        // Mac and Linux swallow 'mousedown' events that close menus.
        e.preventDefault();
        e.stopPropagation();
      }
    } else {
      e.preventDefault();
    }
    break;
  ...
}

[yamaguchi, 2017-04-12 09:08:52]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 09:09:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 11:51:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 11:51:44]

Dry run: This issue passed the CQ dry run.

[yamaguchi, 2017-04-12 12:02:55]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 12:03:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2017-04-12 12:59:24]

https://codereview.chromium.org/2800383002/diff/20001/ui/webui/resources/js/c...
File ui/webui/resources/js/cr/ui/context_menu_handler.js (left):

https://codereview.chromium.org/2800383002/diff/20001/ui/webui/resources/js/c...
ui/webui/resources/js/cr/ui/context_menu_handler.js:160: }
On 2017/04/11 23:43:51, Dan Beam wrote:
> please add this code back but do something like this:
> 
> switch (e.type) {
>   case 'mousedown':
>     if (!this.menu.contains(e.target)) {
>       this.hideMenu();
>       if (e.button == 0 && (cr.isLinux || cr.isMac)) {
>         // Mac and Linux swallow 'mousedown' events that close menus.
>         e.preventDefault();
>         e.stopPropagation();
>       }
>     } else {
>       e.preventDefault();
>     }
>     break;
>   ...
> }

Done.

[commit-bot: I haz the power, 2017-04-12 13:02:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 13:02:39]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2017-04-12 16:07:56]

lgtm

[michaelpg, 2017-04-12 19:24:55]

lgtm, thanks!

https://codereview.chromium.org/2800383002/diff/60001/ui/webui/resources/js/c...
File ui/webui/resources/js/cr/ui/context_menu_handler.js (right):

https://codereview.chromium.org/2800383002/diff/60001/ui/webui/resources/js/c...
ui/webui/resources/js/cr/ui/context_menu_handler.js:158: // Mac and Linux
swallow 'mousedown' events that close menus.
nit: for the next person who updates this, clarify that the goal is consistency
with Mac and Linux -- not responding to something Mac and Linux actually do
here. e.g.:
    // Emulate Mac and Linux, which swallow native 'mousedown' events
    // that close menus.

[yamaguchi, 2017-04-13 01:03:52]

Thanks for reviewing!

https://codereview.chromium.org/2800383002/diff/60001/ui/webui/resources/js/c...
File ui/webui/resources/js/cr/ui/context_menu_handler.js (right):

https://codereview.chromium.org/2800383002/diff/60001/ui/webui/resources/js/c...
ui/webui/resources/js/cr/ui/context_menu_handler.js:158: // Mac and Linux
swallow 'mousedown' events that close menus.
On 2017/04/12 19:24:55, michaelpg wrote:
> nit: for the next person who updates this, clarify that the goal is
consistency
> with Mac and Linux -- not responding to something Mac and Linux actually do
> here. e.g.:
>     // Emulate Mac and Linux, which swallow native 'mousedown' events
>     // that close menus.

Done.

[yamaguchi, 2017-04-13 01:04:18]

The CQ bit was checked by yamaguchi@chromium.org

[yamaguchi, 2017-04-13 01:04:18]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org,
michaelpg@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2800383002/#ps80001
(title: "Update comment to be more descriptive of the change we make.")

[commit-bot: I haz the power, 2017-04-13 01:06:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 03:51:06]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492045458273240,
"parent_rev": "c035f184530b4a493f56a30f114e049e3d9c5cff", "commit_rev":
"3ce9680f3fb4648e3d1ff964f25648eb01fcb579"}

[commit-bot: I haz the power, 2017-04-13 03:51:57]

Description was changed from

==========
Stop blocking the mousedown event of left click when closing context menu.

This change will enable to choose a file and close a context menu
simultaneously by a single click in the file list of the Files app.

Before this change, only the mousedown event of a left click which
dismisses the context menu of cr.ui was blocked its propagation.
It was introduced by https://codereview.chromium.org/1431103003,
which was been directed to 487194 and 507681.
This change will partially remove the change made by that, however,
I think Issue 507681 was resolved by the change to apps_page.js, and
487194 was done by that of title_page.js in the original change.
I confirmed that the both issues doesn't reappear by this change.

BUG=679982
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Stop blocking the mousedown event of left click when closing context menu.

This change will enable to choose a file and close a context menu
simultaneously by a single click in the file list of the Files app.

Before this change, only the mousedown event of a left click which
dismisses the context menu of cr.ui was blocked its propagation.
It was introduced by https://codereview.chromium.org/1431103003,
which was been directed to 487194 and 507681.
This change will partially remove the change made by that, however,
I think Issue 507681 was resolved by the change to apps_page.js, and
487194 was done by that of title_page.js in the original change.
I confirmed that the both issues doesn't reappear by this change.

BUG=679982
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2800383002
Cr-Commit-Position: refs/heads/master@{#464285}
Committed:
https://chromium.googlesource.com/chromium/src/+/3ce9680f3fb4648e3d1ff964f256...
==========

[commit-bot: I haz the power, 2017-04-13 03:52:00]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/3ce9680f3fb4648e3d1ff964f256...