Remove hack for handling accessibility action on ARC notifications.

Remove hack for handling accessibility action on ARC notifications.

This hack was introduced in crrev.com/2767253005 because accessibility
actions generated by automation API were not propagated to the targeted
View before crrev.com/2767143007.
After crrev.com/2767143007, any accessibility actions are propagated to
the targeted View via |HandleAccessibileAction|.

BUG=None
TEST=No change in behavior

Review-Url: https://codereview.chromium.org/2800373002
Cr-Commit-Position: refs/heads/master@{#468570}
Committed: https://chromium.googlesource.com/chromium/src/+/4cf4e3ec453a6ce9715be3d8cf539d78bfce10b3

[yhanada, 2017-04-11 08:48:12]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 08:48:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 10:38:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 10:38:42]

Dry run: This issue passed the CQ dry run.

[yhanada, 2017-04-11 15:29:09]

yhanada@chromium.org changed reviewers:
+ yoshiki@chromium.org

[yhanada, 2017-04-11 15:29:10]

PTAL

[yoshiki, 2017-04-12 08:45:23]

LGTM. Could you add the bug or CL number you added the hack at to this
description?

[yhanada, 2017-04-12 09:04:38]

Description was changed from

==========
Remove hack for handling accessibility action on ARC notifications.

- Use |HandleAccessibleAction| instead.

BUG=None
TEST=No change in behavior
==========

to

==========
Remove hack for handling accessibility action on ARC notifications.

This hack was introduced in crrev.com/2767253005 because accessibility
actions generated by automation API were not propagated to the targeted
View before crrev.com/2767143007.
After crrev.com/2767143007, any accessibility actions are propagated to
the targeted View via |HandleAccessibileAction|.

BUG=None
TEST=No change in behavior
==========

[yhanada, 2017-04-12 09:04:55]

On 2017/04/12 08:45:23, yoshiki wrote:
> LGTM. Could you add the bug or CL number you added the hack at to this
> description?

Updated the description. Thanks!

[yhanada, 2017-04-26 08:31:54]

yhanada@chromium.org changed reviewers:
+ dmazzoni@chromium.org, hidehiko@chromium.org

[yhanada, 2017-04-26 08:31:54]

hidehiko@: Could you review the change of ui/arc/BUILD.gn?
dmazzoni@: I added a dependency to ui/accessibility. PTAL.

[yhanada, 2017-05-01 08:45:14]

hidehiko@, dmazzoni@: ping?

[hidehiko, 2017-05-01 08:48:48]

ui/arc/ LGTM.
(Very sorry for delay. Please feel free to ping me, if you do not receive any
response from me in 24 hrs.)

[yhanada, 2017-05-01 09:15:45]

On 2017/05/01 08:48:48, hidehiko wrote:
> ui/arc/ LGTM.
> (Very sorry for delay. Please feel free to ping me, if you do not receive any
> response from me in 24 hrs.)

No problem. I also forgot this CL :)

[dmazzoni, 2017-05-01 16:03:36]

lgtm

https://codereview.chromium.org/2800373002/diff/60001/ui/arc/BUILD.gn
File ui/arc/BUILD.gn (right):

https://codereview.chromium.org/2800373002/diff/60001/ui/arc/BUILD.gn#newcode30
ui/arc/BUILD.gn:30: "//ui/accessibility:accessibility",
nit: you can just do "//ui/accessibility"

[yhanada, 2017-05-02 02:23:37]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 02:24:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhanada, 2017-05-02 02:24:46]

hidehiko@: I updated ui/arc/BUILD.gn. Could you review the file once again?

https://codereview.chromium.org/2800373002/diff/60001/ui/arc/BUILD.gn
File ui/arc/BUILD.gn (right):

https://codereview.chromium.org/2800373002/diff/60001/ui/arc/BUILD.gn#newcode30
ui/arc/BUILD.gn:30: "//ui/accessibility:accessibility",
On 2017/05/01 16:03:36, dmazzoni wrote:
> nit: you can just do "//ui/accessibility"

Done.

[commit-bot: I haz the power, 2017-05-02 02:55:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 02:55:13]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[yhanada, 2017-05-02 04:10:06]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 04:10:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 05:08:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 05:08:10]

Dry run: This issue passed the CQ dry run.

[hidehiko, 2017-05-02 06:00:31]

On 2017/05/02 02:24:46, yhanada wrote:
> hidehiko@: I updated ui/arc/BUILD.gn. Could you review the file once again?
> 
> https://codereview.chromium.org/2800373002/diff/60001/ui/arc/BUILD.gn
> File ui/arc/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2800373002/diff/60001/ui/arc/BUILD.gn#newcode30
> ui/arc/BUILD.gn:30: "//ui/accessibility:accessibility",
> On 2017/05/01 16:03:36, dmazzoni wrote:
> > nit: you can just do "//ui/accessibility"
> 
> Done.

still lgtm.

[yhanada, 2017-05-02 06:02:50]

Thank you all for reviewing.

[yhanada, 2017-05-02 06:02:55]

The CQ bit was checked by yhanada@chromium.org

[yhanada, 2017-05-02 06:02:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
yoshiki@chromium.org, dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2800373002/#ps80001
(title: ""ui/accessibility:accessibility" -> "ui/accessibility"")

[commit-bot: I haz the power, 2017-05-02 06:03:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 06:08:25]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493704975837860,
"parent_rev": "97e2e2a80810368ef54b61ddfe1f529cdb801cf2", "commit_rev":
"4cf4e3ec453a6ce9715be3d8cf539d78bfce10b3"}

[commit-bot: I haz the power, 2017-05-02 06:08:52]

Description was changed from

==========
Remove hack for handling accessibility action on ARC notifications.

This hack was introduced in crrev.com/2767253005 because accessibility
actions generated by automation API were not propagated to the targeted
View before crrev.com/2767143007.
After crrev.com/2767143007, any accessibility actions are propagated to
the targeted View via |HandleAccessibileAction|.

BUG=None
TEST=No change in behavior
==========

to

==========
Remove hack for handling accessibility action on ARC notifications.

This hack was introduced in crrev.com/2767253005 because accessibility
actions generated by automation API were not propagated to the targeted
View before crrev.com/2767143007.
After crrev.com/2767143007, any accessibility actions are propagated to
the targeted View via |HandleAccessibileAction|.

BUG=None
TEST=No change in behavior

Review-Url: https://codereview.chromium.org/2800373002
Cr-Commit-Position: refs/heads/master@{#468570}
Committed:
https://chromium.googlesource.com/chromium/src/+/4cf4e3ec453a6ce9715be3d8cf53...
==========

[commit-bot: I haz the power, 2017-05-02 06:08:53]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/4cf4e3ec453a6ce9715be3d8cf53...