Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2800343005: Update selection of resolution policy for screen capture with getUserMedia. (Closed)

Created:
3 years, 8 months ago by Guido Urdaneta
Modified:
3 years, 8 months ago
Reviewers:
hbos_chromium
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, avayvod+watch_chromium.org, darin-cc_chromium.org, jasonroberts+watch_google.com, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update selection of resolution policy for screen capture with getUserMedia. The intent of the new algorithm is to allow resolution adjustment if the resolution range allowed by constraints is a superset of the capabilities. However, the actual capabilities are not currently known and, in practice, resolution adjustment was allowed only when no constraints were specified. This CL relaxes this rule to allow resolution adjustment by treating a max constraint as if it were the actual capability. This should be updated so that the actual native screen resolution is used as capability, but, in the meantime, this fix is more compatible with existing applications that expect the behavior of the old algorithm. Moreover, this patch does not affect spec compliance since screen-resolution policies are not regulated by the spec as long as the output resolution is within the constrained range. BUG=709915 Review-Url: https://codereview.chromium.org/2800343005 Cr-Commit-Position: refs/heads/master@{#463309} Committed: https://chromium.googlesource.com/chromium/src/+/71ffa0d2e073d09d8098b0794f7f382655aabedc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -4 lines) Patch
M content/renderer/media/media_stream_constraints_util_video_content.cc View 1 chunk +17 lines, -4 lines 0 comments Download
M content/renderer/media/media_stream_constraints_util_video_content_unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Guido Urdaneta
Hi, PTAL
3 years, 8 months ago (2017-04-10 15:45:31 UTC) #2
hbos_chromium
lgtm
3 years, 8 months ago (2017-04-10 15:50:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800343005/1
3 years, 8 months ago (2017-04-10 15:55:38 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 17:27:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/71ffa0d2e073d09d8098b0794f7f...

Powered by Google App Engine
This is Rietveld 408576698