Revert of mash: Remove ChromeLauncherController's |id_to_item_controller_map_|.

Revert of mash: Remove ChromeLauncherController's |id_to_item_controller_map_|. (patchset #4 id:60001 of https://codereview.chromium.org/2798173002/ )

Reason for revert:
Seems to be causing unit test failures on Linux Chrome OS debug builder, see crbug.com/709729

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/24583

Original issue's description:
> mash: Remove ChromeLauncherController's |id_to_item_controller_map_|.
> 
> Remove CLC::id_to_item_controller_map_; rely on ShelfModel instead.
> Skip removing shelf items in CLC destruction; rely on ~ShelfModel instead.
> 
> Remove CLC::[Get|Set]ShelfItemDelegate helpers; inline ShelfModel calls.
> Remove moot ShelfModelObserver::OnSetShelfItemDelegate.
> 
> Rename CLC::LauncherItemClosed -> RemoveShelfItem.
> Rename test helper GetAppLaunchers -> GetPinnedAppIds.
> 
> Inline ShelfModel::RemoveShelfItemDelegate helper function.
> Avoid GetItemIndexForType, use GetShelfIDForAppID instead.
> Use ItemTypeIsPinned helper function.
> 
> BUG=557406
> TEST=Automated; no Chrome OS shelf behavior changes.
> R=jamescook@chromium.org
> 
> Review-Url: https://codereview.chromium.org/2798173002
> Cr-Commit-Position: refs/heads/master@{#463030}
> Committed: https://chromium.googlesource.com/chromium/src/+/4a3c245c97370cf05dcbe6e9dae89936042293b1

TBR=msw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=557406
Review-Url: https://codereview.chromium.org/2800263002
Cr-Commit-Position: refs/heads/master@{#463122}
Committed: https://chromium.googlesource.com/chromium/src/+/f5acfec7937a8d80bea8a35f5056ffbbaca3bffd

[James Cook, 2017-04-08 04:41:23]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2017-04-08 04:41:23]

Created Revert of mash: Remove ChromeLauncherController's
|id_to_item_controller_map_|.

[commit-bot: I haz the power, 2017-04-08 04:41:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-08 04:43:16]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491626483082330, "parent_rev":
"a35a1e2ce2ab74eccc467aa390eda1a8e29e3e09", "commit_rev":
"f5acfec7937a8d80bea8a35f5056ffbbaca3bffd"}

[commit-bot: I haz the power, 2017-04-08 04:44:02]

Description was changed from

==========
Revert of mash: Remove ChromeLauncherController's |id_to_item_controller_map_|.
(patchset #4 id:60001 of https://codereview.chromium.org/2798173002/ )

Reason for revert:
Seems to be causing unit test failures on Linux Chrome OS debug builder, see
crbug.com/709729

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...

Original issue's description:
> mash: Remove ChromeLauncherController's |id_to_item_controller_map_|.
> 
> Remove CLC::id_to_item_controller_map_; rely on ShelfModel instead.
> Skip removing shelf items in CLC destruction; rely on ~ShelfModel instead.
> 
> Remove CLC::[Get|Set]ShelfItemDelegate helpers; inline ShelfModel calls.
> Remove moot ShelfModelObserver::OnSetShelfItemDelegate.
> 
> Rename CLC::LauncherItemClosed -> RemoveShelfItem.
> Rename test helper GetAppLaunchers -> GetPinnedAppIds.
> 
> Inline ShelfModel::RemoveShelfItemDelegate helper function.
> Avoid GetItemIndexForType, use GetShelfIDForAppID instead.
> Use ItemTypeIsPinned helper function.
> 
> BUG=557406
> TEST=Automated; no Chrome OS shelf behavior changes.
> R=jamescook@chromium.org
> 
> Review-Url: https://codereview.chromium.org/2798173002
> Cr-Commit-Position: refs/heads/master@{#463030}
> Committed:
https://chromium.googlesource.com/chromium/src/+/4a3c245c97370cf05dcbe6e9dae8...

TBR=msw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=557406
==========

to

==========
Revert of mash: Remove ChromeLauncherController's |id_to_item_controller_map_|.
(patchset #4 id:60001 of https://codereview.chromium.org/2798173002/ )

Reason for revert:
Seems to be causing unit test failures on Linux Chrome OS debug builder, see
crbug.com/709729

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...

Original issue's description:
> mash: Remove ChromeLauncherController's |id_to_item_controller_map_|.
> 
> Remove CLC::id_to_item_controller_map_; rely on ShelfModel instead.
> Skip removing shelf items in CLC destruction; rely on ~ShelfModel instead.
> 
> Remove CLC::[Get|Set]ShelfItemDelegate helpers; inline ShelfModel calls.
> Remove moot ShelfModelObserver::OnSetShelfItemDelegate.
> 
> Rename CLC::LauncherItemClosed -> RemoveShelfItem.
> Rename test helper GetAppLaunchers -> GetPinnedAppIds.
> 
> Inline ShelfModel::RemoveShelfItemDelegate helper function.
> Avoid GetItemIndexForType, use GetShelfIDForAppID instead.
> Use ItemTypeIsPinned helper function.
> 
> BUG=557406
> TEST=Automated; no Chrome OS shelf behavior changes.
> R=jamescook@chromium.org
> 
> Review-Url: https://codereview.chromium.org/2798173002
> Cr-Commit-Position: refs/heads/master@{#463030}
> Committed:
https://chromium.googlesource.com/chromium/src/+/4a3c245c97370cf05dcbe6e9dae8...

TBR=msw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=557406

Review-Url: https://codereview.chromium.org/2800263002
Cr-Commit-Position: refs/heads/master@{#463122}
Committed:
https://chromium.googlesource.com/chromium/src/+/f5acfec7937a8d80bea8a35f5056...
==========

[commit-bot: I haz the power, 2017-04-08 04:44:03]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f5acfec7937a8d80bea8a35f5056...