third_party/WebKit/Source/core/inspector/IdentifiersFactory.h - Issue 2800213002: Avoid duplicate functions/code in core/inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/IdentifiersFactory.h

Issue 2800213002: Avoid duplicate functions/code in core/inspector.

Patch Set: Addressed review comments. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/IdentifiersFactory.h

diff --git a/third_party/WebKit/Source/core/inspector/IdentifiersFactory.h b/third_party/WebKit/Source/core/inspector/IdentifiersFactory.h

index 2ed649da30f51f3b79de92a3efb03b87167eaf6c..0d4592f78c92d844602b888075e1d89b48e0a6f8 100644

--- a/third_party/WebKit/Source/core/inspector/IdentifiersFactory.h

+++ b/third_party/WebKit/Source/core/inspector/IdentifiersFactory.h

@@ -45,6 +45,8 @@ class CORE_EXPORT IdentifiersFactory {

static String RequestId(unsigned long identifier);

static String FrameId(LocalFrame*);

+ static String FrameIdSafe(LocalFrame*);

pfeldman 2017/07/25 00:14:43 You no longer need this.

static LocalFrame* FrameById(InspectedFrames*, const String&);

static String LoaderId(DocumentLoader*);