third_party/WebKit/Source/core/inspector/IdentifiersFactory.h - Issue 2800213002: Avoid duplicate functions/code in core/inspector.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/inspector/IdentifiersFactory.h

Issue 2800213002: Avoid duplicate functions/code in core/inspector.

Patch Set: Addressed review comments. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/DOMPatchSupport.cpp ('k') | third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2011 Google Inc. All rights reserved.	2 * Copyright (C) 2011 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 27 matching lines...) Expand all Loading...
38	38

39 class CORE_EXPORT IdentifiersFactory {	39 class CORE_EXPORT IdentifiersFactory {

40 STATIC_ONLY(IdentifiersFactory);	40 STATIC_ONLY(IdentifiersFactory);

41	41

42 public:	42 public:

43 static String CreateIdentifier();	43 static String CreateIdentifier();

44	44

45 static String RequestId(unsigned long identifier);	45 static String RequestId(unsigned long identifier);

46	46

47 static String FrameId(LocalFrame*);	47 static String FrameId(LocalFrame*);

	48 static String FrameIdSafe(LocalFrame*);
	pfeldman 2017/07/25 00:14:43 You no longer need this. You no longer need this.
	49

48 static LocalFrame* FrameById(InspectedFrames*, const String&);	50 static LocalFrame* FrameById(InspectedFrames*, const String&);

49	51

50 static String LoaderId(DocumentLoader*);	52 static String LoaderId(DocumentLoader*);

51 static DocumentLoader* LoaderById(InspectedFrames*, const String&);	53 static DocumentLoader* LoaderById(InspectedFrames*, const String&);

52	54

53 private:	55 private:

54 static String AddProcessIdPrefixTo(int id);	56 static String AddProcessIdPrefixTo(int id);

55 static int RemoveProcessIdPrefixFrom(const String&, bool* ok);	57 static int RemoveProcessIdPrefixFrom(const String&, bool* ok);

56 };	58 };

57	59

58 } // namespace blink	60 } // namespace blink

59	61

60 #endif // IdentifiersFactory_h	62 #endif // IdentifiersFactory_h

OLD	NEW