Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/inspector/BUILD.gn

Issue 2800213002: Avoid duplicate functions/code in core/inspector.
Patch Set: Merge two UrlWithoutFragment() and two FrameId() functions. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/IdentifiersFactory.h » ('j') | third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/inspector/BUILD.gn
diff --git a/third_party/WebKit/Source/core/inspector/BUILD.gn b/third_party/WebKit/Source/core/inspector/BUILD.gn
index ca9d502c51fb85e6775bbf28bb86a6e147972847..e23cca42ef183417fa3d2d6aa40e5221f9bb974c 100644
--- a/third_party/WebKit/Source/core/inspector/BUILD.gn
+++ b/third_party/WebKit/Source/core/inspector/BUILD.gn
@@ -32,6 +32,7 @@ blink_core_sources("inspector") {
"InspectorAnimationAgent.h",
"InspectorApplicationCacheAgent.cpp",
"InspectorApplicationCacheAgent.h",
+ "InspectorBaseAgent.cpp",
"InspectorBaseAgent.h",
"InspectorCSSAgent.cpp",
"InspectorCSSAgent.h",
@@ -98,13 +99,6 @@ blink_core_sources("inspector") {
# Collides with DOMPatchSupport.cpp (patch incoming)
"InspectorAnimationAgent.cpp",
- # Collides with InspectorPageAgent.cpp and
- # NetworkResourcesData.cpp (patch incoming)
- "InspectorNetworkAgent.cpp",
-
- # Collides with InspectorPageAgent.cpp (patch incoming)
- "MainThreadDebugger.cpp",
-
"InspectorOverlayAgent.cpp", # Way too many different "Response"
"InspectorEmulationAgent.cpp", # Way too many different "Response"
]
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/IdentifiersFactory.h » ('j') | third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698