Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: third_party/WebKit/Source/core/inspector/BUILD.gn

Issue 2800213002: Avoid duplicate functions/code in core/inspector.
Patch Set: Merge two UrlWithoutFragment() and two FrameId() functions. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//third_party/WebKit/Source/bindings/bindings.gni") 5 import("//third_party/WebKit/Source/bindings/bindings.gni")
6 import("//third_party/WebKit/Source/core/core.gni") 6 import("//third_party/WebKit/Source/core/core.gni")
7 import("//third_party/inspector_protocol/inspector_protocol.gni") 7 import("//third_party/inspector_protocol/inspector_protocol.gni")
8 import("//v8/gni/v8.gni") 8 import("//v8/gni/v8.gni")
9 9
10 _inspector_protocol_dir = "//third_party/inspector_protocol" 10 _inspector_protocol_dir = "//third_party/inspector_protocol"
(...skipping 14 matching lines...) Expand all
25 "DevToolsHost.cpp", 25 "DevToolsHost.cpp",
26 "DevToolsHost.h", 26 "DevToolsHost.h",
27 "IdentifiersFactory.cpp", 27 "IdentifiersFactory.cpp",
28 "IdentifiersFactory.h", 28 "IdentifiersFactory.h",
29 "InspectedFrames.cpp", 29 "InspectedFrames.cpp",
30 "InspectedFrames.h", 30 "InspectedFrames.h",
31 "InspectorAnimationAgent.cpp", 31 "InspectorAnimationAgent.cpp",
32 "InspectorAnimationAgent.h", 32 "InspectorAnimationAgent.h",
33 "InspectorApplicationCacheAgent.cpp", 33 "InspectorApplicationCacheAgent.cpp",
34 "InspectorApplicationCacheAgent.h", 34 "InspectorApplicationCacheAgent.h",
35 "InspectorBaseAgent.cpp",
35 "InspectorBaseAgent.h", 36 "InspectorBaseAgent.h",
36 "InspectorCSSAgent.cpp", 37 "InspectorCSSAgent.cpp",
37 "InspectorCSSAgent.h", 38 "InspectorCSSAgent.h",
38 "InspectorDOMAgent.cpp", 39 "InspectorDOMAgent.cpp",
39 "InspectorDOMAgent.h", 40 "InspectorDOMAgent.h",
40 "InspectorDOMDebuggerAgent.cpp", 41 "InspectorDOMDebuggerAgent.cpp",
41 "InspectorDOMDebuggerAgent.h", 42 "InspectorDOMDebuggerAgent.h",
42 "InspectorDOMSnapshotAgent.cpp", 43 "InspectorDOMSnapshotAgent.cpp",
43 "InspectorDOMSnapshotAgent.h", 44 "InspectorDOMSnapshotAgent.h",
44 "InspectorEmulationAgent.cpp", 45 "InspectorEmulationAgent.cpp",
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 "WorkerInspectorController.cpp", 92 "WorkerInspectorController.cpp",
92 "WorkerInspectorController.h", 93 "WorkerInspectorController.h",
93 "WorkerThreadDebugger.cpp", 94 "WorkerThreadDebugger.cpp",
94 "WorkerThreadDebugger.h", 95 "WorkerThreadDebugger.h",
95 ] 96 ]
96 97
97 jumbo_excluded_sources = [ 98 jumbo_excluded_sources = [
98 # Collides with DOMPatchSupport.cpp (patch incoming) 99 # Collides with DOMPatchSupport.cpp (patch incoming)
99 "InspectorAnimationAgent.cpp", 100 "InspectorAnimationAgent.cpp",
100 101
101 # Collides with InspectorPageAgent.cpp and
102 # NetworkResourcesData.cpp (patch incoming)
103 "InspectorNetworkAgent.cpp",
104
105 # Collides with InspectorPageAgent.cpp (patch incoming)
106 "MainThreadDebugger.cpp",
107
108 "InspectorOverlayAgent.cpp", # Way too many different "Response" 102 "InspectorOverlayAgent.cpp", # Way too many different "Response"
109 "InspectorEmulationAgent.cpp", # Way too many different "Response" 103 "InspectorEmulationAgent.cpp", # Way too many different "Response"
110 ] 104 ]
111 105
112 configs += [ 106 configs += [
113 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. 107 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
114 "//build/config/compiler:no_size_t_to_int_warning", 108 "//build/config/compiler:no_size_t_to_int_warning",
115 ] 109 ]
116 } 110 }
117 111
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
253 outputs = [ 247 outputs = [
254 output_file, 248 output_file,
255 ] 249 ]
256 250
257 args = [ 251 args = [
258 rebase_path("browser_protocol.json", root_build_dir), 252 rebase_path("browser_protocol.json", root_build_dir),
259 rebase_path(v8_inspector_js_protocol, root_build_dir), 253 rebase_path(v8_inspector_js_protocol, root_build_dir),
260 rebase_path(output_file, root_build_dir), 254 rebase_path(output_file, root_build_dir),
261 ] 255 ]
262 } 256 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698