Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 2800173002: Remove ScriptState::setExecutionContext (Closed)

Created:
3 years, 8 months ago by adithyas
Modified:
3 years, 8 months ago
Reviewers:
haraken, jbroman
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScriptState::setExecutionContext The function doesn't appear to be used anywhere, and adds an unnecessary dependency to ExecutionContext in ScriptState. BUG=682322 Review-Url: https://codereview.chromium.org/2800173002 Cr-Commit-Position: refs/heads/master@{#463013} Committed: https://chromium.googlesource.com/chromium/src/+/bbf236a7a16a07ccea034d5cbaf480318cc6a99c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptState.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
adithyas
3 years, 8 months ago (2017-04-07 19:44:27 UTC) #3
jbroman
lgtm
3 years, 8 months ago (2017-04-07 19:47:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800173002/1
3 years, 8 months ago (2017-04-07 21:19:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/bbf236a7a16a07ccea034d5cbaf480318cc6a99c
3 years, 8 months ago (2017-04-07 21:51:04 UTC) #12
haraken
3 years, 8 months ago (2017-04-07 22:38:29 UTC) #13
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698