Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2800153002: Fix static initializers in RlzValueStoreChromeOS. (Closed)

Created:
3 years, 8 months ago by Lei Zhang
Modified:
3 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix static initializers in RlzValueStoreChromeOS. BUG=537099 Review-Url: https://codereview.chromium.org/2800153002 Cr-Commit-Position: refs/heads/master@{#463004} Committed: https://chromium.googlesource.com/chromium/src/+/8d3a19a335b7331b9253c5be0dea1562f79ba3a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -21 lines) Patch
M rlz/chromeos/lib/rlz_value_store_chromeos.h View 2 chunks +2 lines, -7 lines 0 comments Download
M rlz/chromeos/lib/rlz_value_store_chromeos.cc View 5 chunks +16 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Lei Zhang
Not sure why we didn't find this one earlier.
3 years, 8 months ago (2017-04-07 19:16:24 UTC) #3
Nico
lgtm We don't have tooling for static initializers on cros :-/
3 years, 8 months ago (2017-04-07 19:39:25 UTC) #5
Lei Zhang
On 2017/04/07 19:39:25, Nico wrote: > We don't have tooling for static initializers on cros ...
3 years, 8 months ago (2017-04-07 20:21:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800153002/1
3 years, 8 months ago (2017-04-07 20:22:01 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 21:14:05 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8d3a19a335b7331b9253c5be0dea...

Powered by Google App Engine
This is Rietveld 408576698