Avoid duplicate functions: one AddStringToDigestor is enough

third_party/WebKit/Source/core/inspector/AddStringToDigestor.cpp

Index: third_party/WebKit/Source/core/inspector/AddStringToDigestor.cpp
diff --git a/third_party/WebKit/Source/core/inspector/AddStringToDigestor.cpp b/third_party/WebKit/Source/core/inspector/AddStringToDigestor.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..96fd29fc412eb21c533019305b9cd5e8f7c795cd
--- /dev/null
+++ b/third_party/WebKit/Source/core/inspector/AddStringToDigestor.cpp
@@ -0,0 +1,17 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/inspector/AddStringToDigestor.h"
+
+#include "platform/wtf/text/WTFString.h"
+#include "public/platform/WebCrypto.h"
+
+namespace blink {
+
+void AddStringToDigestor(WebCryptoDigestor* digestor, const String& string) {
+  digestor->Consume(
+      reinterpret_cast<const unsigned char*>(string.Ascii().data()),

[alph, 2017/07/08 01:16:24]

I bet string.Ascii().length() is not equal to string.length()
Also let's use Utf8() instead.

[Daniel Bratell, 2017/07/10 14:47:18]

So thanks to your review I realized that the two functions are not identical.
One does ASCII and one does UTF-8. So merging them will mean a change. I did a
new patch which keeps the old behaviour, but if you prefer this, I can switch to
utf-8 instead.

[alph, 2017/07/10 21:26:06]

I believe it's not really important which encoding to use (ascii or utf8) as it
just needs calculate a hash of the string. So I believe you can merge the
functions. 

+      string.length());
+}
+}  // namespace blink