third_party/WebKit/Source/core/inspector/AddStringToDigestor.cpp - Issue 2800133003: Avoid duplicate functions: one AddStringToDigestor is enough

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/inspector/AddStringToDigestor.cpp

Issue 2800133003: Avoid duplicate functions: one AddStringToDigestor is enough (Closed)

Patch Set: Avoid duplicate functions/code: one AddStringToDigestor is enough. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/core/inspector/AddStringToDigestor.h ('K') | « third_party/WebKit/Source/core/inspector/AddStringToDigestor.h ('k') | third_party/WebKit/Source/core/inspector/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "core/inspector/AddStringToDigestor.h"

	6

	7 #include "platform/wtf/text/WTFString.h"

	8 #include "public/platform/WebCrypto.h"

	9

	10 namespace blink {

	11

	12 void AddStringToDigestor(WebCryptoDigestor* digestor, const String& string) {

	13 digestor->Consume(

	14 reinterpret_cast<const unsigned char*>(string.Ascii().data()),
	alph 2017/07/08 01:16:24 I bet string.Ascii().length() is not equal to stri I bet string.Ascii().length() is not equal to string.length() Also let's use Utf8() instead. Daniel Bratell 2017/07/10 14:47:18 So thanks to your review I realized that the two f Show quoted text On 2017/07/08 01:16:24, alph wrote: > I bet string.Ascii().length() is not equal to string.length() > Also let's use Utf8() instead. So thanks to your review I realized that the two functions are not identical. One does ASCII and one does UTF-8. So merging them will mean a change. I did a new patch which keeps the old behaviour, but if you prefer this, I can switch to utf-8 instead. alph 2017/07/10 21:26:06 I believe it's not really important which encoding Show quoted text On 2017/07/10 14:47:18, Daniel Bratell wrote: > On 2017/07/08 01:16:24, alph wrote: > > I bet string.Ascii().length() is not equal to string.length() > > Also let's use Utf8() instead. > > So thanks to your review I realized that the two functions are not identical. > One does ASCII and one does UTF-8. So merging them will mean a change. I did a > new patch which keeps the old behaviour, but if you prefer this, I can switch to > utf-8 instead. I believe it's not really important which encoding to use (ascii or utf8) as it just needs calculate a hash of the string. So I believe you can merge the functions.
	15 string.length());

	16 }

	17 } // namespace blink

OLD	NEW