Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2800133002: Include what you use for thread_task_runner_handle.h in components/. (Closed)

Created:
3 years, 8 months ago by fdoray
Modified:
3 years, 8 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, cbentzel+watch_chromium.org, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, asvitkine+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Include what you use for thread_task_runner_handle.h in components/. BUG= Review-Url: https://codereview.chromium.org/2800133002 Cr-Commit-Position: refs/heads/master@{#463252} Committed: https://chromium.googlesource.com/chromium/src/+/3a0a2d0be1753b4844e64ae1c65fdc66dd1f36f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M components/metrics/net/network_metrics_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/ntp_tiles/most_visited_sites_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/ukm/ukm_service.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
fdoray
PTAL
3 years, 8 months ago (2017-04-10 12:43:16 UTC) #7
sdefresne
lgtm
3 years, 8 months ago (2017-04-10 13:02:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800133002/1
3 years, 8 months ago (2017-04-10 13:04:07 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/187300) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-04-10 13:07:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800133002/1
3 years, 8 months ago (2017-04-10 13:54:14 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 14:07:32 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3a0a2d0be1753b4844e64ae1c65f...

Powered by Google App Engine
This is Rietveld 408576698