DescriptionRevert of Use dropdown list for admin areas in pr form. (patchset #18 id:1000001 of https://codereview.chromium.org/2680143002/ )
Reason for revert:
The patch causes chrome_public_test_apk failing on chromium.android/Marshmallow Tablet Tester: crbug.com/709491.
Original issue's description:
> Use drop-down list for admin areas (state, province, ..)
>
> -- In the payment request form (instead of the previous text-field).
>
> - For this purpose, the rules of the specified country are loaded from
> the i18n aggregate server, and the country's sub-keys are retrieved from the right rule.
>
> - If the server doesn't respond, or there is a time-out, or if no
> admin areas are recorded for that country, show text-field.
>
> -- Add all the fields to the form, only when admin areas are loaded.
> This way we can have the fields in order. Otherwise, admin areas
> would show up at the end (since they are fetched asynchronously.)
>
> - In the Payment Request tests, the admin area field would always be a
> text field (and not a drop down). This way, the tests would be
> independent of the network connection state.
>
> - Tests were added to the AddressValidatorTest according to the
> changes.
>
> BUG=675634
>
> Review-Url: https://codereview.chromium.org/2680143002
> Cr-Commit-Position: refs/heads/master@{#462611}
> Committed: https://chromium.googlesource.com/chromium/src/+/69b196d676ecbbb986009aaf9f5627fd6e332de1
TBR=sebsg@chromium.org,mathp@chromium.org,rouslan@chromium.org,dfalcantara@chromium.org,parastoog@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=675634
Review-Url: https://codereview.chromium.org/2800013004
Cr-Commit-Position: refs/heads/master@{#462867}
Committed: https://chromium.googlesource.com/chromium/src/+/d93ff442df53bb6e2ac7ccb153192ab73524477b
Patch Set 1 #Messages
Total messages: 6 (3 generated)
|