Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2800013004: Revert of Use dropdown list for admin areas in pr form. (Closed)

Created:
3 years, 8 months ago by Xi Han
Modified:
3 years, 8 months ago
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use dropdown list for admin areas in pr form. (patchset #18 id:1000001 of https://codereview.chromium.org/2680143002/ ) Reason for revert: The patch causes chrome_public_test_apk failing on chromium.android/Marshmallow Tablet Tester: crbug.com/709491. Original issue's description: > Use drop-down list for admin areas (state, province, ..) > > -- In the payment request form (instead of the previous text-field). > > - For this purpose, the rules of the specified country are loaded from > the i18n aggregate server, and the country's sub-keys are retrieved from the right rule. > > - If the server doesn't respond, or there is a time-out, or if no > admin areas are recorded for that country, show text-field. > > -- Add all the fields to the form, only when admin areas are loaded. > This way we can have the fields in order. Otherwise, admin areas > would show up at the end (since they are fetched asynchronously.) > > - In the Payment Request tests, the admin area field would always be a > text field (and not a drop down). This way, the tests would be > independent of the network connection state. > > - Tests were added to the AddressValidatorTest according to the > changes. > > BUG=675634 > > Review-Url: https://codereview.chromium.org/2680143002 > Cr-Commit-Position: refs/heads/master@{#462611} > Committed: https://chromium.googlesource.com/chromium/src/+/69b196d676ecbbb986009aaf9f5627fd6e332de1 TBR=sebsg@chromium.org,mathp@chromium.org,rouslan@chromium.org,dfalcantara@chromium.org,parastoog@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=675634 Review-Url: https://codereview.chromium.org/2800013004 Cr-Commit-Position: refs/heads/master@{#462867} Committed: https://chromium.googlesource.com/chromium/src/+/d93ff442df53bb6e2ac7ccb153192ab73524477b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -485 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java View 8 chunks +11 lines, -64 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java View 11 chunks +60 lines, -163 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java View 4 chunks +1 line, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java View 2 chunks +1 line, -12 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java View 1 chunk +1 line, -22 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/android/personal_data_manager_android.h View 4 chunks +2 lines, -52 lines 0 comments Download
M chrome/browser/autofill/android/personal_data_manager_android.cc View 6 chunks +3 lines, -98 lines 0 comments Download
M components/payments/core/address_normalizer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/payments/core/address_normalizer.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/libaddressinput/chromium/chrome_address_validator.h View 2 chunks +2 lines, -9 lines 0 comments Download
M third_party/libaddressinput/chromium/chrome_address_validator.cc View 4 chunks +1 line, -17 lines 0 comments Download
M third_party/libaddressinput/chromium/chrome_address_validator_unittest.cc View 7 chunks +8 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Xi Han
Created Revert of Use dropdown list for admin areas in pr form.
3 years, 8 months ago (2017-04-07 15:38:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800013004/1
3 years, 8 months ago (2017-04-07 15:38:53 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 15:40:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d93ff442df53bb6e2ac7ccb15319...

Powered by Google App Engine
This is Rietveld 408576698