Remove vestigial Context arguments in ExternalAuthUtils, part 1/3

Remove vestigial Context arguments in ExternalAuthUtils, part 1/3

BUG=709208
Review-Url: https://codereview.chromium.org/2800013002
Cr-Commit-Position: refs/heads/master@{#462737}
Committed: https://chromium.googlesource.com/chromium/src/+/b728a75415b10f5cf4ca4e1cd1d3cadc615b02d6

[paulmiller, 2017-04-06 22:16:41]

Description was changed from

==========
Remove vestigial Context arguments in ExternalAuthUtils, part 1/3

BUG=709208
==========

to

==========
Remove vestigial Context arguments in ExternalAuthUtils, part 1/3

BUG=709208
==========

[paulmiller, 2017-04-06 22:16:41]

paulmiller@chromium.org changed reviewers:
+ mariakhomenko@chromium.org

[paulmiller, 2017-04-06 22:18:13]

On 2017/04/06 22:16:41, paulmiller wrote:
> mailto:paulmiller@chromium.org changed reviewers:
> + mailto:mariakhomenko@chromium.org

PTAL. Noticed this while updating deprecated GMS APIs. See
https://crbug.com/709208#c1 for the plan.

[Maria, 2017-04-06 23:23:15]

https://codereview.chromium.org/2800013002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/externalauth/ExternalAuthUtils.java
(right):

https://codereview.chromium.org/2800013002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/externalauth/ExternalAuthUtils.java:110:
return isGoogleSigned(null, packageName);
shouldn't you be calling isGoogleSigned(packageName) here instead?

[paulmiller, 2017-04-06 23:25:56]

https://codereview.chromium.org/2800013002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/externalauth/ExternalAuthUtils.java
(right):

https://codereview.chromium.org/2800013002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/externalauth/ExternalAuthUtils.java:110:
return isGoogleSigned(null, packageName);
On 2017/04/06 23:23:15, Maria wrote:
> shouldn't you be calling isGoogleSigned(packageName) here instead?

Not yet. Downstream still overrides the old isGoogleSigned. This way,
isChromeGoogleSigned will keep the same behavior now and when I switch
downstream to override the new isGoogleSigned. Then on the 3rd change (see the
plan on the bug) I'll do as you say.

[Maria, 2017-04-06 23:37:11]

https://codereview.chromium.org/2800013002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/externalauth/ExternalAuthUtils.java
(right):

https://codereview.chromium.org/2800013002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/externalauth/ExternalAuthUtils.java:110:
return isGoogleSigned(null, packageName);
On 2017/04/06 23:25:56, paulmiller wrote:
> On 2017/04/06 23:23:15, Maria wrote:
> > shouldn't you be calling isGoogleSigned(packageName) here instead?
> 
> Not yet. Downstream still overrides the old isGoogleSigned. This way,
> isChromeGoogleSigned will keep the same behavior now and when I switch
> downstream to override the new isGoogleSigned. Then on the 3rd change (see the
> plan on the bug) I'll do as you say.

There's no reason not to switch it right now. This function isn't going to be
called by anyone until after CL#3 is landed, no?

[Maria, 2017-04-06 23:42:28]

lgtm

Either way is not a big deal

[paulmiller, 2017-04-07 00:49:17]

The CQ bit was checked by paulmiller@chromium.org

[commit-bot: I haz the power, 2017-04-07 00:49:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 01:34:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491526157725090, "parent_rev":
"9bfd22cbbe910fe0123f328832c3c384434fdbbf", "commit_rev":
"b728a75415b10f5cf4ca4e1cd1d3cadc615b02d6"}

[commit-bot: I haz the power, 2017-04-07 01:35:13]

Description was changed from

==========
Remove vestigial Context arguments in ExternalAuthUtils, part 1/3

BUG=709208
==========

to

==========
Remove vestigial Context arguments in ExternalAuthUtils, part 1/3

BUG=709208

Review-Url: https://codereview.chromium.org/2800013002
Cr-Commit-Position: refs/heads/master@{#462737}
Committed:
https://chromium.googlesource.com/chromium/src/+/b728a75415b10f5cf4ca4e1cd1d3...
==========

[commit-bot: I haz the power, 2017-04-07 01:35:14]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b728a75415b10f5cf4ca4e1cd1d3...