Setting convolver buffer needs to update number of output channels

Setting convolver buffer needs to update number of output channels

When the buffer for a ConvolverNode is set, the number of outputs
needs to be reconfigured based on the number of channels in the
response buffer.

BUG=709150
TEST=Convolver/convolver-response-4-chan.html

Review-Url: https://codereview.chromium.org/2799993002
Cr-Commit-Position: refs/heads/master@{#462888}
Committed: https://chromium.googlesource.com/chromium/src/+/26d2eea286b0c0ecc81ef2cf52815942d788ce1b

[Raymond Toy, 2017-04-06 22:57:58]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-04-06 22:57:58]

PTAL

[hongchan, 2017-04-06 23:03:25]

lgtm with style nits.

https://codereview.chromium.org/2799993002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-response-4-chan.html
(right):

https://codereview.chromium.org/2799993002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-response-4-chan.html:110:
let convolver = new ConvolverNode(context, {disableNormalization: true});
Please wrap at 80.

https://codereview.chromium.org/2799993002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-response-4-chan.html:112:
sampleRate: context.sampleRate});
Not properly indented.

https://codereview.chromium.org/2799993002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-response-4-chan.html:123:
.then(() => {
We can remove the wrapping braces and make it into one line, just like l.126.

https://codereview.chromium.org/2799993002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-response-4-chan.html:131:
// Just make sure output is not silent
super nit: add a period at the end.

https://codereview.chromium.org/2799993002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-response-4-chan.html:133:
"Output with delayed setting of convolver buffer")
Please use single quotes.

[Raymond Toy, 2017-04-07 14:51:48]

https://codereview.chromium.org/2799993002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-response-4-chan.html
(right):

https://codereview.chromium.org/2799993002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-response-4-chan.html:110:
let convolver = new ConvolverNode(context, {disableNormalization: true});
On 2017/04/06 23:03:24, hongchan wrote:
> Please wrap at 80.

Done.

https://codereview.chromium.org/2799993002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-response-4-chan.html:112:
sampleRate: context.sampleRate});
On 2017/04/06 23:03:24, hongchan wrote:
> Not properly indented.

Done.

https://codereview.chromium.org/2799993002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-response-4-chan.html:123:
.then(() => {
On 2017/04/06 23:03:24, hongchan wrote:
> We can remove the wrapping braces and make it into one line, just like l.126.

Done.

https://codereview.chromium.org/2799993002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-response-4-chan.html:131:
// Just make sure output is not silent
On 2017/04/06 23:03:24, hongchan wrote:
> super nit: add a period at the end.

Done.

https://codereview.chromium.org/2799993002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-response-4-chan.html:133:
"Output with delayed setting of convolver buffer")
On 2017/04/06 23:03:24, hongchan wrote:
> Please use single quotes.

Done.

[Raymond Toy, 2017-04-07 14:52:02]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-04-07 14:52:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2799993002/#ps40001
(title: "Address review comments")

[commit-bot: I haz the power, 2017-04-07 14:52:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 16:29:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491576722865150,
"parent_rev": "8a9962171b6d2f8e98c9d312c433087425b3f154", "commit_rev":
"26d2eea286b0c0ecc81ef2cf52815942d788ce1b"}

[commit-bot: I haz the power, 2017-04-07 16:30:14]

Description was changed from

==========
Setting convolver buffer needs to update number of output channels

When the buffer for a ConvolverNode is set, the number of outputs
needs to be reconfigured based on the number of channels in the
response buffer.

BUG=709150
TEST=Convolver/convolver-response-4-chan.html
==========

to

==========
Setting convolver buffer needs to update number of output channels

When the buffer for a ConvolverNode is set, the number of outputs
needs to be reconfigured based on the number of channels in the
response buffer.

BUG=709150
TEST=Convolver/convolver-response-4-chan.html

Review-Url: https://codereview.chromium.org/2799993002
Cr-Commit-Position: refs/heads/master@{#462888}
Committed:
https://chromium.googlesource.com/chromium/src/+/26d2eea286b0c0ecc81ef2cf5281...
==========

[commit-bot: I haz the power, 2017-04-07 16:30:15]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/26d2eea286b0c0ecc81ef2cf5281...