Handle ExternalStrings directly in the serializer without ObjectVisitor.

Handle ExternalStrings directly in the serializer without ObjectVisitor.

The serializer already has code that special cases for some external
strings. We can handle all external strings in one place instead of
splitting the logic between the serializer and the object visitor.

The main benefit is that we remove two virtual functions from the
ObjectVisitor and thus simplify it for all other users.

BUG=chromium:709075
Review-Url: https://codereview.chromium.org/2799943002
Cr-Commit-Position: refs/heads/master@{#44485}
Committed: https://chromium.googlesource.com/v8/v8/+/039617d75483e10ded4d60d08d684bba08d8bdb9

[ulan, 2017-04-06 17:53:07]

ulan@chromium.org changed reviewers:
+ yangguo@chromium.org

[ulan, 2017-04-06 17:53:08]

ptal

https://codereview.chromium.org/2799943002/diff/1/src/snapshot/serializer.cc
File src/snapshot/serializer.cc (right):

https://codereview.chromium.org/2799943002/diff/1/src/snapshot/serializer.cc#...
src/snapshot/serializer.cc:421: CHECK_EQ(0, bytes_processed_so_far_);
Lines 413-421 are from the Serialize function.

The remaining lines are from the former VisitOneByteExternalString function.

https://codereview.chromium.org/2799943002/diff/1/src/snapshot/serializer.cc#...
src/snapshot/serializer.cc:448: Isolate* isolate = serializer_->isolate();
This function moved without any change.

https://codereview.chromium.org/2799943002/diff/1/src/snapshot/serializer.cc#...
src/snapshot/serializer.cc:582: int size = object_->Size();
This code just moved verbatim from 529.

[Yang, 2017-04-07 11:56:20]

lgtm

[ulan, 2017-04-07 11:57:45]

Description was changed from

==========
Handle ExternalStrings direcly in the serializer without ObjectVisitor.

The serializer already has code that special cases for some external
strings. We can handle all external strings in one place instead of
splitting the logic between the serializer and the object visitor.

The main benefit is that we remove two virtual functions from the
ObjectVisitor and thus simplify it for all other users.

BUG=chromium:709075
==========

to

==========
Handle ExternalStrings directly in the serializer without ObjectVisitor.

The serializer already has code that special cases for some external
strings. We can handle all external strings in one place instead of
splitting the logic between the serializer and the object visitor.

The main benefit is that we remove two virtual functions from the
ObjectVisitor and thus simplify it for all other users.

BUG=chromium:709075
==========

[ulan, 2017-04-07 11:57:51]

The CQ bit was checked by ulan@chromium.org

[commit-bot: I haz the power, 2017-04-07 11:57:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 12:24:22]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491566271769850, "parent_rev":
"e6ca01463de333bd4069d23c616c26647897e749", "commit_rev":
"039617d75483e10ded4d60d08d684bba08d8bdb9"}

[commit-bot: I haz the power, 2017-04-07 12:24:30]

Description was changed from

==========
Handle ExternalStrings directly in the serializer without ObjectVisitor.

The serializer already has code that special cases for some external
strings. We can handle all external strings in one place instead of
splitting the logic between the serializer and the object visitor.

The main benefit is that we remove two virtual functions from the
ObjectVisitor and thus simplify it for all other users.

BUG=chromium:709075
==========

to

==========
Handle ExternalStrings directly in the serializer without ObjectVisitor.

The serializer already has code that special cases for some external
strings. We can handle all external strings in one place instead of
splitting the logic between the serializer and the object visitor.

The main benefit is that we remove two virtual functions from the
ObjectVisitor and thus simplify it for all other users.

BUG=chromium:709075

Review-Url: https://codereview.chromium.org/2799943002
Cr-Commit-Position: refs/heads/master@{#44485}
Committed:
https://chromium.googlesource.com/v8/v8/+/039617d75483e10ded4d60d08d684bba08d...
==========

[commit-bot: I haz the power, 2017-04-07 12:24:31]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/039617d75483e10ded4d60d08d684bba08d...