Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 2799933003: Allow 'enable_package_mash_services' GN flag to be functional for non-chromeos builds (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 2 weeks ago by tonikitoo
Modified:
3 months, 2 weeks ago
CC:
chromium-reviews, msisov
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow 'enable_package_mash_services' GN flag to be functional for non-chromeos builds The ENABLE_PACKAGE_MASH_SERVICES compile flag is enabled in accordance to its gn variable counterpart, $enable_package_mash_services, which by default is enabled for ChromeOS builds: see chrome/common/features.gni enable_package_mash_services = is_chromeos Until [1], it was possible to set enable_package_mash_services=true for non-ChromeOS builds (e.g. ozone/linux os) and then make ::MashMain codepath accessible (triggered by --mus and --mash command line parameters). This CL relaxes the ChromeOS enforcement so that `chrome --mus` linux/ozone builds continue to launch on off-trunk [2]. For ChromeOS matters, it does not change anything. [1] https://codereview.chromium.org/2755813002/diff/300001/chrome/app/chrome_main.cc [2] https://github.com/Igalia/chromium/tree/ozone-wayland-dev R=ben@chromium.org BUG=None

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/chrome_main.cc View 1 chunk +1 line, -1 line 0 comments Download
Trybot results:  mac_chromium_rel_ng   mac_chromium_compile_dbg_ng   win_clang   win_chromium_x64_rel_ng   win_chromium_compile_dbg_ng   win_chromium_rel_ng   mac_chromium_rel_ng   mac_chromium_compile_dbg_ng   ios-simulator-xcode-clang   ios-simulator   ios-device-xcode-clang   ios-device   linux_chromium_rel_ng   linux_chromium_tsan_rel_ng   linux_chromium_chromeos_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_chromeos_ozone_rel_ng   chromium_presubmit   linux_chromium_asan_rel_ng   chromeos_daisy_chromium_compile_only_ng   chromeos_amd64-generic_chromium_compile_only_ng   cast_shell_linux   linux_android_rel_ng   cast_shell_android   android_cronet   android_n5x_swarming_rel   android_clang_dbg_recipe   android_compile_dbg   android_arm64_dbg_recipe   win_clang   win_chromium_x64_rel_ng   win_chromium_rel_ng   win_chromium_compile_dbg_ng   mac_chromium_rel_ng   mac_chromium_compile_dbg_ng   ios-simulator   ios-simulator-xcode-clang   ios-device-xcode-clang   ios-device   linux_chromium_tsan_rel_ng   linux_chromium_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_chromeos_rel_ng   linux_chromium_asan_rel_ng   linux_chromium_chromeos_ozone_rel_ng   chromium_presubmit   chromeos_daisy_chromium_compile_only_ng   chromeos_amd64-generic_chromium_compile_only_ng   linux_android_rel_ng   cast_shell_linux   cast_shell_android   android_n5x_swarming_rel   android_cronet   android_compile_dbg   android_clang_dbg_recipe   android_arm64_dbg_recipe 
Commit queue not available (can’t edit this change).

Messages

Total messages: 16 (11 generated)
tonikitoo
ben: PTAL
5 months, 2 weeks ago (2017-04-07 16:03:57 UTC) #3
tonikitoo
On 2017/04/07 16:03:57, tonikitoo wrote: > ben: PTAL gentle ping review.
4 months, 1 week ago (2017-05-16 04:28:04 UTC) #11
Ben Goodger (Google)
lgtm
4 months, 1 week ago (2017-05-16 04:31:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799933003/1
4 months, 1 week ago (2017-05-16 04:33:51 UTC) #14
commit-bot: I haz the power
4 months, 1 week ago (2017-05-16 04:37:20 UTC) #16
Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b