|
|
DescriptionAllow 'enable_package_mash_services' GN flag to be functional for non-chromeos builds
The ENABLE_PACKAGE_MASH_SERVICES compile flag is enabled in
accordance to its gn variable counterpart, $enable_package_mash_services,
which by default is enabled for ChromeOS builds:
see chrome/common/features.gni
enable_package_mash_services = is_chromeos
Until [1], it was possible to set enable_package_mash_services=true
for non-ChromeOS builds (e.g. ozone/linux os) and then make
::MashMain codepath accessible (triggered by --mus and --mash
command line parameters).
This CL relaxes the ChromeOS enforcement so that `chrome --mus`
linux/ozone builds continue to launch on off-trunk [2]. For
ChromeOS matters, it does not change anything.
[1] https://codereview.chromium.org/2755813002/diff/300001/chrome/app/chrome_main.cc
[2] https://github.com/Igalia/chromium/tree/ozone-wayland-dev
R=ben@chromium.org
BUG=None
Patch Set 1 #
Messages
Total messages: 16 (11 generated)
The CQ bit was checked by tonikitoo@igalia.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ben: PTAL
Description was changed from ========== Allow 'enable_package_mash_services' GN flag to be functional for non-chromeos builds The ENABLE_PACKAGE_MASH_SERVICES compile flag is enabled in accordance to its gn variable counterpart, $enable_package_mash_services. Until [1], it was possible to set enable_package_mash_services=true for non chromeos builds (e.g. ozone/linux os) and the MashMain codepath was accessible (triggered by --mus and --mash command line parameters). This CL relaxes the chromeos enforcement so that chrome --mus on off-trunk [2] linux/ozone builds continue to launch. [1] https://codereview.chromium.org/2755813002 [2] https://github.com/Igalia/chromium/tree/ozone-wayland-dev R=ben@chromium.org BUG=None ========== to ========== Allow 'enable_package_mash_services' GN flag to be functional for non-chromeos builds The ENABLE_PACKAGE_MASH_SERVICES compile flag is enabled in accordance to its gn variable counterpart, $enable_package_mash_services, which by default is enabled for ChromeOS builds. Until [1], it was possible to set enable_package_mash_services=true for non-ChromeOS builds (e.g. ozone/linux os) and the MashMain codepath was accessible (triggered by --mus and --mash command line parameters). This CL relaxes the ChromeOS enforcement so that `chrome --mus` on off-trunk [2] linux/ozone builds continue to launch. [1] https://codereview.chromium.org/2755813002 [2] https://github.com/Igalia/chromium/tree/ozone-wayland-dev R=ben@chromium.org BUG=None ==========
tonikitoo@igalia.com changed reviewers: + sky@chromium.org
Description was changed from ========== Allow 'enable_package_mash_services' GN flag to be functional for non-chromeos builds The ENABLE_PACKAGE_MASH_SERVICES compile flag is enabled in accordance to its gn variable counterpart, $enable_package_mash_services, which by default is enabled for ChromeOS builds. Until [1], it was possible to set enable_package_mash_services=true for non-ChromeOS builds (e.g. ozone/linux os) and the MashMain codepath was accessible (triggered by --mus and --mash command line parameters). This CL relaxes the ChromeOS enforcement so that `chrome --mus` on off-trunk [2] linux/ozone builds continue to launch. [1] https://codereview.chromium.org/2755813002 [2] https://github.com/Igalia/chromium/tree/ozone-wayland-dev R=ben@chromium.org BUG=None ========== to ========== Allow 'enable_package_mash_services' GN flag to be functional for non-chromeos builds The ENABLE_PACKAGE_MASH_SERVICES compile flag is enabled in accordance to its gn variable counterpart, $enable_package_mash_services, which by default is enabled for ChromeOS builds: see chrome/common/features.gni enable_package_mash_services = is_chromeos Until [1], it was possible to set enable_package_mash_services=true for non-ChromeOS builds (e.g. ozone/linux os) and then make ::MashMain codepath accessible (triggered by --mus and --mash command line parameters). This CL relaxes the ChromeOS enforcement so that `chrome --mus` linux/ozone builds continue to launch on off-trunk [2]. For ChromeOS matters, it does not change anything. [1] https://codereview.chromium.org/2755813002 [2] https://github.com/Igalia/chromium/tree/ozone-wayland-dev R=ben@chromium.org BUG=None ==========
Description was changed from ========== Allow 'enable_package_mash_services' GN flag to be functional for non-chromeos builds The ENABLE_PACKAGE_MASH_SERVICES compile flag is enabled in accordance to its gn variable counterpart, $enable_package_mash_services, which by default is enabled for ChromeOS builds: see chrome/common/features.gni enable_package_mash_services = is_chromeos Until [1], it was possible to set enable_package_mash_services=true for non-ChromeOS builds (e.g. ozone/linux os) and then make ::MashMain codepath accessible (triggered by --mus and --mash command line parameters). This CL relaxes the ChromeOS enforcement so that `chrome --mus` linux/ozone builds continue to launch on off-trunk [2]. For ChromeOS matters, it does not change anything. [1] https://codereview.chromium.org/2755813002 [2] https://github.com/Igalia/chromium/tree/ozone-wayland-dev R=ben@chromium.org BUG=None ========== to ========== Allow 'enable_package_mash_services' GN flag to be functional for non-chromeos builds The ENABLE_PACKAGE_MASH_SERVICES compile flag is enabled in accordance to its gn variable counterpart, $enable_package_mash_services, which by default is enabled for ChromeOS builds: see chrome/common/features.gni enable_package_mash_services = is_chromeos Until [1], it was possible to set enable_package_mash_services=true for non-ChromeOS builds (e.g. ozone/linux os) and then make ::MashMain codepath accessible (triggered by --mus and --mash command line parameters). This CL relaxes the ChromeOS enforcement so that `chrome --mus` linux/ozone builds continue to launch on off-trunk [2]. For ChromeOS matters, it does not change anything. [1] https://codereview.chromium.org/2755813002 [2] https://github.com/Igalia/chromium/tree/ozone-wayland-dev R=ben@chromium.org BUG=None ==========
Description was changed from ========== Allow 'enable_package_mash_services' GN flag to be functional for non-chromeos builds The ENABLE_PACKAGE_MASH_SERVICES compile flag is enabled in accordance to its gn variable counterpart, $enable_package_mash_services, which by default is enabled for ChromeOS builds: see chrome/common/features.gni enable_package_mash_services = is_chromeos Until [1], it was possible to set enable_package_mash_services=true for non-ChromeOS builds (e.g. ozone/linux os) and then make ::MashMain codepath accessible (triggered by --mus and --mash command line parameters). This CL relaxes the ChromeOS enforcement so that `chrome --mus` linux/ozone builds continue to launch on off-trunk [2]. For ChromeOS matters, it does not change anything. [1] https://codereview.chromium.org/2755813002 [2] https://github.com/Igalia/chromium/tree/ozone-wayland-dev R=ben@chromium.org BUG=None ========== to ========== Allow 'enable_package_mash_services' GN flag to be functional for non-chromeos builds The ENABLE_PACKAGE_MASH_SERVICES compile flag is enabled in accordance to its gn variable counterpart, $enable_package_mash_services, which by default is enabled for ChromeOS builds: see chrome/common/features.gni enable_package_mash_services = is_chromeos Until [1], it was possible to set enable_package_mash_services=true for non-ChromeOS builds (e.g. ozone/linux os) and then make ::MashMain codepath accessible (triggered by --mus and --mash command line parameters). This CL relaxes the ChromeOS enforcement so that `chrome --mus` linux/ozone builds continue to launch on off-trunk [2]. For ChromeOS matters, it does not change anything. [1] https://codereview.chromium.org/2755813002/diff/300001/chrome/app/chrome_main.cc [2] https://github.com/Igalia/chromium/tree/ozone-wayland-dev R=ben@chromium.org BUG=None ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/04/07 16:03:57, tonikitoo wrote: > ben: PTAL gentle ping review.
lgtm
The CQ bit was checked by tonikitoo@igalia.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) |