Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issue 2799893002: Rewrite flaky canvas test to testharness.js to sidestep issue (Closed)

Created:
3 years, 8 months ago by foolip
Modified:
3 years, 8 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite flaky canvas test to testharness.js to sidestep issue BUG=708919 R=junov@chromium.org Review-Url: https://codereview.chromium.org/2799893002 Cr-Commit-Position: refs/heads/master@{#462775} Committed: https://chromium.googlesource.com/chromium/src/+/18bf204d6960d6074f8bb5be4fb93af9e92ed908

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -87 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-lose-restore-googol-size.html View 1 chunk +37 lines, -62 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-lose-restore-googol-size-expected.txt View 1 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
foolip
3 years, 8 months ago (2017-04-06 07:30:49 UTC) #1
Justin Novosad
On 2017/04/06 07:30:49, foolip_UTC7 wrote: lgtm
3 years, 8 months ago (2017-04-06 19:46:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799893002/20001
3 years, 8 months ago (2017-04-07 05:34:09 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 05:41:48 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/18bf204d6960d6074f8bb5be4fb9...

Powered by Google App Engine
This is Rietveld 408576698