Fixing the pink toolbar icons in Chrome Remote Desktop Android app

Fixing the pink toolbar icons in Chrome Remote Desktop Android app

On certain platforms, the icons in our toolbar were tinted pink instead
of dark grey.  I tracked this down to the API we use to retrieve the
icon color.  We retrieve the color by using a resourceID from the current
context and pass it to a Chromium compat API.  The problem is that our
resourceID is based on the current Theme and the compat getColor method
is not Theme aware.  Therefore the ID retrieves a different color
resource than what we expected.  Note that this is only a problem on M
and later releases.

The fix for us is to just use the Android ContextCompat class for the
color lookup instead of the Chromium version.

BUG=704150
Review-Url: https://codereview.chromium.org/2799803004
Cr-Commit-Position: refs/heads/master@{#462682}
Committed: https://chromium.googlesource.com/chromium/src/+/2fd7014105d562d587191d8875f98e448ce45508

[joedow, 2017-04-06 22:58:13]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 22:58:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joedow, 2017-04-06 22:58:51]

joedow@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[joedow, 2017-04-06 22:58:52]

PTAL!

[commit-bot: I haz the power, 2017-04-06 23:13:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 23:13:22]

Dry run: This issue passed the CQ dry run.

[Lambros, 2017-04-06 23:14:37]

The CQ bit was checked by lambroslambrou@chromium.org

[Lambros, 2017-04-06 23:14:38]

lgtm

[commit-bot: I haz the power, 2017-04-06 23:15:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 23:35:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491520477628570, "parent_rev":
"a83d784a8c9979237fcce6b513bcae4a5abd0a81", "commit_rev":
"2fd7014105d562d587191d8875f98e448ce45508"}

[commit-bot: I haz the power, 2017-04-06 23:36:29]

Description was changed from

==========
Fixing the pink toolbar icons in Chrome Remote Desktop Android app

On certain platforms, the icons in our toolbar were tinted pink instead
of dark grey.  I tracked this down to the API we use to retrieve the
icon color.  We retrieve the color by using a resourceID from the current
context and pass it to a Chromium compat API.  The problem is that our
resourceID is based on the current Theme and the compat getColor method
is not Theme aware.  Therefore the ID retrieves a different color
resource than what we expected.  Note that this is only a problem on M
and later releases.

The fix for us is to just use the Android ContextCompat class for the
color lookup instead of the Chromium version.

BUG=704150
==========

to

==========
Fixing the pink toolbar icons in Chrome Remote Desktop Android app

On certain platforms, the icons in our toolbar were tinted pink instead
of dark grey.  I tracked this down to the API we use to retrieve the
icon color.  We retrieve the color by using a resourceID from the current
context and pass it to a Chromium compat API.  The problem is that our
resourceID is based on the current Theme and the compat getColor method
is not Theme aware.  Therefore the ID retrieves a different color
resource than what we expected.  Note that this is only a problem on M
and later releases.

The fix for us is to just use the Android ContextCompat class for the
color lookup instead of the Chromium version.

BUG=704150

Review-Url: https://codereview.chromium.org/2799803004
Cr-Commit-Position: refs/heads/master@{#462682}
Committed:
https://chromium.googlesource.com/chromium/src/+/2fd7014105d562d587191d8875f9...
==========

[commit-bot: I haz the power, 2017-04-06 23:36:33]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2fd7014105d562d587191d8875f9...