Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2799803002: Add a test for webview using a blob URL while at a webview-accessible resource. (Closed)

Created:
3 years, 8 months ago by alexmos
Modified:
3 years, 8 months ago
Reviewers:
wjmaclean
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a test for webview using a blob URL while at a webview-accessible resource. This was written to try out a theory on issue 706537. Nothing turned out not to be broken, but I thought this test might be useful anyway. There doesn't appear to be an existing test for this, and it gets us some coverage for behavior on which the ChromeOS Files app relies. BUG=640072, 706537 Review-Url: https://codereview.chromium.org/2799803002 Cr-Commit-Position: refs/heads/master@{#462246} Committed: https://chromium.googlesource.com/chromium/src/+/968dd8975ab73d3abecd20c171bd4e3a6af7bf71

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/load_webview_accessible_resource/embedder.js View 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
alexmos
James, can you please take a look?
3 years, 8 months ago (2017-04-05 20:58:25 UTC) #5
wjmaclean
On 2017/04/05 20:58:25, alexmos wrote: > James, can you please take a look? lgtm, thanks ...
3 years, 8 months ago (2017-04-05 21:08:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799803002/1
3 years, 8 months ago (2017-04-05 21:41:31 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 22:28:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/968dd8975ab73d3abecd20c171bd...

Powered by Google App Engine
This is Rietveld 408576698